Also improve comments so I don't keep forgetting what I did
This commit is contained in:
parent
5498186cf1
commit
051bb9f1e3
|
@ -225,7 +225,7 @@ class ProfileDownloadFragment : BaseMaterialDialogFragment(),
|
||||||
confirmationCode: String?,
|
confirmationCode: String?,
|
||||||
imei: String?
|
imei: String?
|
||||||
) = beginTrackedOperation {
|
) = beginTrackedOperation {
|
||||||
channel.lpa.downloadProfile(
|
val res = channel.lpa.downloadProfile(
|
||||||
server,
|
server,
|
||||||
code,
|
code,
|
||||||
imei,
|
imei,
|
||||||
|
@ -239,8 +239,14 @@ class ProfileDownloadFragment : BaseMaterialDialogFragment(),
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
|
if (!res) {
|
||||||
|
// TODO: Provide more details on the error
|
||||||
|
throw RuntimeException("Failed to download profile; this is typically caused by another error happened before.")
|
||||||
|
}
|
||||||
|
|
||||||
// If we get here, we are successful
|
// If we get here, we are successful
|
||||||
// Only send notifications if the user allowed us to
|
// This function is wrapped in beginTrackedOperation, so by returning the settings value,
|
||||||
|
// We only send notifications if the user allowed us to
|
||||||
preferenceRepository.notificationDownloadFlow.first()
|
preferenceRepository.notificationDownloadFlow.first()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue