From 3a860601a34f8c48cb6669d50252d3787b87cdca Mon Sep 17 00:00:00 2001
From: Peter Cai <peter@typeblog.net>
Date: Fri, 20 Dec 2024 19:32:58 -0500
Subject: [PATCH 1/2] ui: Optimize ATR strings

---
 .../src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt  | 2 +-
 app-common/src/main/res/values/strings.xml                    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app-common/src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt b/app-common/src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt
index 735166d..b303e33 100644
--- a/app-common/src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt
+++ b/app-common/src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt
@@ -137,7 +137,7 @@ class EuiccInfoActivity : BaseEuiccAccessActivity(), OpenEuiccContextMarker {
         add(
             Item(
                 R.string.euicc_info_atr,
-                channel.atr?.encodeHex() ?: getString(R.string.euicc_info_atr_unavailable),
+                channel.atr?.encodeHex() ?: getString(R.string.unavailable),
                 copiedToastResId = R.string.toast_atr_copied,
             )
         )
diff --git a/app-common/src/main/res/values/strings.xml b/app-common/src/main/res/values/strings.xml
index 4723e88..bc46825 100644
--- a/app-common/src/main/res/values/strings.xml
+++ b/app-common/src/main/res/values/strings.xml
@@ -3,6 +3,7 @@
     <string name="no_euicc">No removable eUICC card accessible by this app is detected on this device. Insert a compatible card or a USB reader.</string>
     <string name="no_profile">No profiles (yet) on this eSIM.</string>
     <string name="unknown">Unknown</string>
+    <string name="unavailable">Unavailable</string>
     <string name="help">Help</string>
     <string name="reload">Reload Slots</string>
 
@@ -133,8 +134,7 @@
     <string name="euicc_info_ci_gsma_live">GSMA Live CI</string>
     <string name="euicc_info_ci_gsma_test">GSMA Test CI</string>
     <string name="euicc_info_ci_unknown">Unknown eSIM CI</string>
-    <string name="euicc_info_atr">ATR (Answer To Reset)</string>
-    <string name="euicc_info_atr_unavailable">ATR unavailable</string>
+    <string name="euicc_info_atr" translatable="false">Answer To Reset (ATR)</string>
 
     <string name="yes">Yes</string>
     <string name="no">No</string>

From d0b3d54c6662be0f6c7e8668ff7389f825d26956 Mon Sep 17 00:00:00 2001
From: Peter Cai <peter@typeblog.net>
Date: Fri, 20 Dec 2024 19:33:43 -0500
Subject: [PATCH 2/2] ui: Allow multi-line strings in EuiccInfoActivity

---
 app-common/src/main/res/layout/euicc_info_item.xml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app-common/src/main/res/layout/euicc_info_item.xml b/app-common/src/main/res/layout/euicc_info_item.xml
index 39d15a6..fa148fb 100644
--- a/app-common/src/main/res/layout/euicc_info_item.xml
+++ b/app-common/src/main/res/layout/euicc_info_item.xml
@@ -22,8 +22,6 @@
         android:layout_height="wrap_content"
         android:layout_marginHorizontal="24dp"
         android:layout_marginVertical="12dp"
-        android:maxLines="1"
-        android:ellipsize="marquee"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toBottomOf="@id/euicc_info_title"