From e1877f5d3ada8d8968d9d05a3ed3ef81c77ef4c2 Mon Sep 17 00:00:00 2001 From: Peter Cai Date: Sun, 14 Jul 2024 21:18:00 -0400 Subject: [PATCH 1/3] Update wording to stress "standard CCID readers" --- app-unpriv/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app-unpriv/src/main/res/values/strings.xml b/app-unpriv/src/main/res/values/strings.xml index 43e57e2..124bedf 100644 --- a/app-unpriv/src/main/res/values/strings.xml +++ b/app-unpriv/src/main/res/values/strings.xml @@ -21,7 +21,7 @@ Oops, your device is known to have bugs when accessing removable eSIMs. This does not necessarily mean that it will not work at all, but you will have to proceed with caution. USB Card Reader Support Does your device support managing eSIMs via USB card readers? - You can manage eSIMs through USB card readers on this device (even if you had any other check items fail here). Insert the card reader and then open this app to manage eSIMs in this way. + You can manage eSIMs through standard USB CCID readers on this device (even if you had any other check items fail here). Insert the card reader and then open this app to manage eSIMs in this way. Your device does not support acting as a USB host. Verdict (non-USB) Based on all previous checks, how likely is your device to be compatible with managing inserted removable eSIMs? From 323c6a5bc00f5a189cdb95bbde0c7580269a71d7 Mon Sep 17 00:00:00 2001 From: Peter Cai Date: Sun, 14 Jul 2024 21:19:27 -0400 Subject: [PATCH 2/3] Update wording to include USB readers when no card found --- app-common/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app-common/src/main/res/values/strings.xml b/app-common/src/main/res/values/strings.xml index caafd5f..4ad6071 100644 --- a/app-common/src/main/res/values/strings.xml +++ b/app-common/src/main/res/values/strings.xml @@ -1,6 +1,6 @@ - No removable eUICC card accessible by this app is detected on this device. + No removable eUICC card accessible by this app is detected on this device. Insert a compatible card or a USB reader. No profiles (yet) on this eSIM. Unknown Help From 7b605fd44a570fa3503fe942f09ff9c5241877cc Mon Sep 17 00:00:00 2001 From: Peter Cai Date: Sun, 14 Jul 2024 21:20:11 -0400 Subject: [PATCH 3/3] Remove unnecessary `var` --- app-common/src/main/java/im/angry/openeuicc/ui/MainActivity.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app-common/src/main/java/im/angry/openeuicc/ui/MainActivity.kt b/app-common/src/main/java/im/angry/openeuicc/ui/MainActivity.kt index fd2d51c..74fe385 100644 --- a/app-common/src/main/java/im/angry/openeuicc/ui/MainActivity.kt +++ b/app-common/src/main/java/im/angry/openeuicc/ui/MainActivity.kt @@ -119,7 +119,7 @@ open class MainActivity : BaseEuiccAccessActivity(), OpenEuiccContextMarker { viewPager.visibility = View.GONE tabs.visibility = View.GONE - var knownChannels = withContext(Dispatchers.IO) { + val knownChannels = withContext(Dispatchers.IO) { euiccChannelManager.enumerateEuiccChannels().onEach { Log.d(TAG, "slot ${it.slotId} port ${it.portId}") Log.d(TAG, it.lpa.eID)