chore: improve lpa string parsing

app-common/src/main/java/im/angry/openeuicc/ui/wizard/DownloadWizardMethodSelectFragment.kt

@@ -126,7 +126,7 @@ class DownloadWizardMethodSelectFragment : DownloadWizardActivity.DownloadWizard
             state.matchingId = parsed.matchingId
             state.confirmationCodeRequired = parsed.confirmationCodeRequired
             gotoNextFragment(DownloadWizardDetailsFragment())
-        } catch (e: IllegalArgumentException) {
+        } catch (e: IllegalStateException) {
             AlertDialog.Builder(requireContext()).apply {
                 setTitle(R.string.profile_download_incorrect_lpa_string)
                 setMessage(R.string.profile_download_incorrect_lpa_string_message)

app-common/src/main/java/im/angry/openeuicc/util/LPAString.kt

@@ -8,15 +8,16 @@ data class LPAString(
 ) {
     companion object {
         fun parse(input: String): LPAString {
-            val components = input.removePrefix("LPA:").split('$')
+            var token = input
-            if (components.size < 2 || components[0] != "1") {
+            if (token.startsWith("LPA:", true)) token = token.drop(4)
-                throw IllegalArgumentException("Invalid activation code format")
+            val components = token.split('$').map { it.trim().ifBlank { null } }
-            }
+            check(components.size > 1) { "Invalid activation code format" }
+            check(components[0] == "1") { "Invalid AC_Format" }
             return LPAString(
-                address = components[1].trim(),
+                checkNotNull(components[1]) { "SM-DP+ is required" },
-                matchingId = components.getOrNull(2)?.trim()?.ifBlank { null },
+                components.getOrNull(2),
-                oid = components.getOrNull(3)?.trim()?.ifBlank { null },
+                components.getOrNull(3),
-                confirmationCodeRequired = components.getOrNull(4)?.trim() == "1"
+                components.getOrNull(4) == "1"
             )
         }
     }