PeterCxy/OpenEUICC
33
62
Fork 40
Code Issues 8 Pull requests 3 Projects Releases 14 Wiki Activity Actions

refactor: profile download callback #284

Merged
PeterCxy merged 2 commits from septs/OpenEUICC:profile-download-callback into master 2026-02-26 02:20:05 +01:00
Conversation 3 Commits 2 Files changed 10 +63 -87
septs commented 2025-12-09 11:19:42 +01:00
Collaborator
Copy link
No description provided.
PeterCxy reviewed 2025-12-13 21:04:44 +01:00
libs/lpac-jni/src/main/java/net/typeblog/lpac_jni/ActivationCode.kt Outdated
@ -0,0 +1,8 @@
package net.typeblog.lpac_jni
data class ActivationCode(
PeterCxy commented 2025-12-13 21:04:44 +01:00
Owner
Copy link

Please do not introduce anything more that's called "Activation Code". This can be named "ProfileDownloadInput" or something along those lines.

Please do not introduce anything more that's called "Activation Code". This can be named "ProfileDownloadInput" or something along those lines.
septs marked this conversation as resolved
PeterCxy reviewed 2025-12-13 21:05:46 +01:00
libs/lpac-jni/src/main/java/net/typeblog/lpac_jni/ProfileDownloadCallback.java Outdated
@ -0,0 +1,5 @@
package net.typeblog.lpac_jni;
public interface ProfileDownloadCallback {
PeterCxy commented 2025-12-13 21:05:46 +01:00
Owner
Copy link

Do not add Java code.

Do not add Java code.
septs marked this conversation as resolved
PeterCxy commented 2025-12-13 21:07:57 +01:00
Owner
Copy link

I'm OK with this but will only merge after the next release.

I'm OK with this but will only merge after the next release.
septs force-pushed profile-download-callback from d4c83328cf to be5b7ac111 2025-12-14 03:13:31 +01:00 Compare
septs force-pushed profile-download-callback from be5b7ac111 to 9e1b4f5d7c 2026-02-24 13:09:45 +01:00 Compare
PeterCxy merged commit b9863e2e54 into master 2026-02-26 02:20:05 +01:00
PeterCxy deleted branch profile-download-callback 2026-02-26 02:20:05 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
PeterCxy/OpenEUICC!284
No description provided.