PeterCxy/OpenEUICC
33
62
Fork 40
Code Issues 8 Pull requests 3 Projects Releases 14 Wiki Activity Actions

Support TPDU-based CCID readers #295

Merged
PeterCxy merged 1 commit from phcoder/OpenEUICC:tpdu into master 2026-02-26 02:22:11 +01:00
Conversation 8 Commits 1 Files changed 3 +138 -1
phcoder commented 2026-01-22 10:04:44 +01:00
Contributor
Copy link

resolves #37

For TPDU based readers like USB 2.0-CRW 2 additional commands are needed in initialisation. Add them

resolves #37 For TPDU based readers like USB 2.0-CRW 2 additional commands are needed in initialisation. Add them
For TPDU based readers like USB 2.0-CRW 2 additional commands are needed in
initialisation. Add them
septs requested changes 2026-01-23 03:00:19 +01:00
Dismissed
septs left a comment
Collaborator
Copy link

Please add some comment, explain the reference standards and sources.

Please add some comment, explain the reference standards and sources.
septs commented 2026-01-23 03:13:08 +01:00
Collaborator
Copy link

Please confirm whether this PR resolved issue #37?

Please confirm whether this PR resolved issue #37?
phcoder commented 2026-01-23 06:53:21 +01:00
Author
Contributor
Copy link

@septs wrote in #295 (comment):

Please add some comment, explain the reference standards and sources.

Done

@septs wrote in https://gitea.angry.im/PeterCxy/OpenEUICC/pulls/295#issuecomment-2000: > Please add some comment, explain the reference standards and sources. Done
phcoder commented 2026-01-23 06:53:40 +01:00
Author
Contributor
Copy link

@septs wrote in #295 (comment):

Please confirm whether this PR resolved issue #37?

Yes, exactly the same reader. I tested it with USB 2.0-CRW and 9esim card. It shows correctly the capacity and card info. I didn't try to actually provision it yet

@septs wrote in https://gitea.angry.im/PeterCxy/OpenEUICC/pulls/295#issuecomment-2001: > Please confirm whether this PR resolved issue #37? Yes, exactly the same reader. I tested it with USB 2.0-CRW and 9esim card. It shows correctly the capacity and card info. I didn't try to actually provision it yet
septs approved these changes 2026-01-23 06:58:40 +01:00
septs left a comment
Collaborator
Copy link

Wait for @PeterCxy

Wait for @PeterCxy
PeterCxy commented 2026-02-24 00:23:20 +01:00
Owner
Copy link

@phcoder Thank you for contributing! I have been on vacation for the past month but I'll review this PR shortly.

@phcoder Thank you for contributing! I have been on vacation for the past month but I'll review this PR shortly.
PeterCxy commented 2026-02-26 02:21:49 +01:00
Owner
Copy link

Since this is mostly an initialization sequence change, LGTM (I can't test myself, though, only looked at the code and it seems reasonable).

Since this is mostly an initialization sequence change, LGTM (I can't test myself, though, only looked at the code and it seems reasonable).
PeterCxy merged commit 2cf2d9490a into master 2026-02-26 02:22:11 +01:00
PeterCxy deleted branch tpdu 2026-02-26 02:22:11 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
septs
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
PeterCxy/OpenEUICC!295
No description provided.