From 16405d2a7026e7c4678a48e285d9787120dc50f9 Mon Sep 17 00:00:00 2001 From: septs Date: Wed, 13 Nov 2024 08:54:32 +0800 Subject: [PATCH] chore: simplify CompatibilityCheckActivity logical --- .../ui/CompatibilityCheckActivity.kt | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/app-unpriv/src/main/java/im/angry/openeuicc/ui/CompatibilityCheckActivity.kt b/app-unpriv/src/main/java/im/angry/openeuicc/ui/CompatibilityCheckActivity.kt index 06b46df..433f9c3 100644 --- a/app-unpriv/src/main/java/im/angry/openeuicc/ui/CompatibilityCheckActivity.kt +++ b/app-unpriv/src/main/java/im/angry/openeuicc/ui/CompatibilityCheckActivity.kt @@ -1,7 +1,6 @@ package im.angry.openeuicc.ui import android.os.Bundle -import android.util.Log import android.view.MenuItem import android.view.View import android.view.ViewGroup @@ -68,20 +67,13 @@ class CompatibilityCheckActivity: AppCompatActivity() { it.visibility = View.GONE } - when (item.state) { - CompatibilityCheck.State.SUCCESS -> { - root.requireViewById(R.id.compatibility_check_checkmark).visibility = View.VISIBLE - } - CompatibilityCheck.State.FAILURE -> { - root.requireViewById(R.id.compatibility_check_error).visibility = View.VISIBLE - } - CompatibilityCheck.State.FAILURE_UNKNOWN -> { - root.requireViewById(R.id.compatibility_check_unknown).visibility = View.VISIBLE - } - else -> { - root.requireViewById(R.id.compatibility_check_progress_bar).visibility = View.VISIBLE - } + val viewId = when (item.state) { + CompatibilityCheck.State.SUCCESS -> R.id.compatibility_check_checkmark + CompatibilityCheck.State.FAILURE -> R.id.compatibility_check_error + CompatibilityCheck.State.FAILURE_UNKNOWN -> R.id.compatibility_check_unknown + else -> R.id.compatibility_check_progress_bar } + root.requireViewById(viewId).visibility = View.VISIBLE } } -- 2.45.3