From 46216d0e61318e7af168e9e903ef8d943bb49b2e Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Wed, 13 Dec 2017 02:48:52 +0000 Subject: [PATCH] Revert "Changes needed to upgrade to new gradle version" This reverts commit ba1332d1b4dd525a2ef313246482708cb2016052. Reason for revert: Broke taimen builds in master Change-Id: Iffffadbacae8c6c69907dcecc447f958cf6ce909 --- .../view/NavigationBarButton.java | 2 - .../items/ExpandableSwitchItemTest.java | 3 +- .../setupwizardlib/items/SwitchItemTest.java | 3 +- .../util/DimensionConsistencyTest.java | 3 +- library/lint.xml | 4 - library/main/res/values/styles.xml | 20 +-- .../util/WizardManagerHelper.java | 12 ++ library/platform/res/values-v23/styles.xml | 4 +- ...ecyclerViewScrollHandlingDelegateTest.java | 3 +- library/rules.gradle | 10 +- library/self.gradle | 25 ++-- .../setupwizardlib/GlifLayoutTest.java | 2 +- .../setupwizardlib/items/ButtonItemTest.java | 5 +- .../setupwizardlib/items/ItemGroupTest.java | 5 +- .../PatchedGradleManifestFactory.java | 126 ++++++++++++++++++ .../SuwLibRobolectricTestRunner.java | 29 ++++ .../setupwizardlib/span/LinkSpanTest.java | 4 +- .../ListViewScrollHandlingDelegateTest.java | 3 +- .../template/RequireScrollMixinTest.java | 3 +- .../ScrollViewScrollHandlingDelegateTest.java | 3 +- .../util/GlifDimensionTest.java | 3 +- .../setupwizardlib/util/GlifStyleTest.java | 3 +- .../setupwizardlib/util/PartnerTest.java | 2 + .../util/WizardManagerHelperTest.java | 3 +- .../view/FillContentLayoutTest.java | 3 +- .../view/IllustrationVideoViewTest.java | 2 + tools/gradle/android.properties | 4 +- 27 files changed, 235 insertions(+), 54 deletions(-) create mode 100644 library/test/robotest/src/com/android/setupwizardlib/robolectric/PatchedGradleManifestFactory.java diff --git a/library/gingerbread/src/com/android/setupwizardlib/view/NavigationBarButton.java b/library/gingerbread/src/com/android/setupwizardlib/view/NavigationBarButton.java index d7a3c2e..5172c47 100644 --- a/library/gingerbread/src/com/android/setupwizardlib/view/NavigationBarButton.java +++ b/library/gingerbread/src/com/android/setupwizardlib/view/NavigationBarButton.java @@ -16,7 +16,6 @@ package com.android.setupwizardlib.view; -import android.annotation.SuppressLint; import android.content.Context; import android.content.res.ColorStateList; import android.graphics.PorterDuff; @@ -31,7 +30,6 @@ import android.widget.Button; * Button for navigation bar, which includes tinting of its compound drawables to be used for dark * and light themes. */ -@SuppressLint("AppCompatCustomView") public class NavigationBarButton extends Button { public NavigationBarButton(Context context) { diff --git a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/ExpandableSwitchItemTest.java b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/ExpandableSwitchItemTest.java index 3020ed3..4fb3e28 100644 --- a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/ExpandableSwitchItemTest.java +++ b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/ExpandableSwitchItemTest.java @@ -32,6 +32,7 @@ import android.widget.FrameLayout; import android.widget.ImageView; import android.widget.TextView; +import com.android.setupwizardlib.BuildConfig; import com.android.setupwizardlib.R; import com.android.setupwizardlib.robolectric.SuwLibRobolectricTestRunner; @@ -43,7 +44,7 @@ import org.robolectric.annotation.Config; import java.util.ArrayList; @RunWith(SuwLibRobolectricTestRunner.class) -@Config(sdk = { Config.OLDEST_SDK, Config.NEWEST_SDK }) +@Config(constants = BuildConfig.class, sdk = { Config.OLDEST_SDK, Config.NEWEST_SDK }) public class ExpandableSwitchItemTest { private TextView mSummaryView; diff --git a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/SwitchItemTest.java b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/SwitchItemTest.java index fa5bbba..d391d80 100644 --- a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/SwitchItemTest.java +++ b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/items/SwitchItemTest.java @@ -31,6 +31,7 @@ import android.widget.FrameLayout; import android.widget.ImageView; import android.widget.TextView; +import com.android.setupwizardlib.BuildConfig; import com.android.setupwizardlib.R; import com.android.setupwizardlib.robolectric.SuwLibRobolectricTestRunner; @@ -39,7 +40,7 @@ import org.junit.runner.RunWith; import org.robolectric.annotation.Config; @RunWith(SuwLibRobolectricTestRunner.class) -@Config(sdk = { Config.OLDEST_SDK, Config.NEWEST_SDK }) +@Config(constants = BuildConfig.class, sdk = { Config.OLDEST_SDK, Config.NEWEST_SDK }) public class SwitchItemTest { private SwitchCompat mSwitch; diff --git a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/util/DimensionConsistencyTest.java b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/util/DimensionConsistencyTest.java index 7a08235..43e7f03 100644 --- a/library/gingerbread/test/robotest/src/com/android/setupwizardlib/util/DimensionConsistencyTest.java +++ b/library/gingerbread/test/robotest/src/com/android/setupwizardlib/util/DimensionConsistencyTest.java @@ -25,6 +25,7 @@ import android.util.DisplayMetrics; import android.util.TypedValue; import android.view.ContextThemeWrapper; +import com.android.setupwizardlib.BuildConfig; import com.android.setupwizardlib.R; import com.android.setupwizardlib.robolectric.SuwLibRobolectricTestRunner; @@ -34,7 +35,7 @@ import org.junit.runner.RunWith; import org.robolectric.annotation.Config; @RunWith(SuwLibRobolectricTestRunner.class) -@Config(sdk = Config.ALL_SDKS) +@Config(constants = BuildConfig.class, sdk = Config.ALL_SDKS) public class DimensionConsistencyTest { // Visual height of the framework switch widget diff --git a/library/lint.xml b/library/lint.xml index 625b20d..ca22c65 100644 --- a/library/lint.xml +++ b/library/lint.xml @@ -1,11 +1,7 @@ - - - - diff --git a/library/main/res/values/styles.xml b/library/main/res/values/styles.xml index e1e229f..0e7685b 100644 --- a/library/main/res/values/styles.xml +++ b/library/main/res/values/styles.xml @@ -32,6 +32,9 @@ top|bottom + + + + @@ -88,10 +94,11 @@ gravity - - + + @@ -204,10 +211,7 @@ false - -