PeterCxy/SetupWizardLibrary
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix Partner.getText

Browse source 
Test: ./gradlew test
Bug: 109781942
Change-Id: I06c3be06def30803e5dda3069686f0ff510b804d
This commit is contained in:
Maurice Lam 2018-06-08 18:33:47 -07:00
parent a65273f3bd
commit 466c50ab5c
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
library/main/src/com/android/setupwizardlib/util/Partner.java
View file

@ -91,7 +91,7 @@ public class Partner {
*/
public static CharSequence getText(Context context, @StringRes int id) {
final ResourceEntry entry = getResourceEntry(context, id);
return entry.resources.getText(id);
return entry.resources.getText(entry.id);
}
/**

15
library/test/robotest/src/com/android/setupwizardlib/util/PartnerTest.java
View file

@ -16,6 +16,8 @@
package com.android.setupwizardlib.util;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
@ -145,6 +147,19 @@ public class PartnerTest {
expectedPartnerColor, foundColor);
}
@Test
public void getText_shouldReturnPartnerValueIfPresent() {
final CharSequence expectedPartnerText = "partner";
doReturn(12345).when(mPartnerResources)
.getIdentifier(eq("suw_next_button_label"), eq("string"), anyString());
doReturn(expectedPartnerText).when(mPartnerResources).getText(eq(12345));
mPackageManager.addResolveInfoForIntent(
new Intent(ACTION_PARTNER_CUSTOMIZATION),
Collections.singletonList(createResolveInfo("test.partner.package", true, true)));
final CharSequence partnerText = Partner.getText(mContext, R.string.suw_next_button_label);
assertThat(partnerText).isEqualTo(expectedPartnerText);
}
@Test
public void testLoadDefaultValue() {
mPackageManager.addResolveInfoForIntent(