do not use Dialer UI for incoming calls if audio permission is not granted

We cannot request new permissions when Dialer UI is shown. For incoming
calls, if the Dialer UI is displayed over keyguard, then the user may
not even be able to see the permission notifications that we use for
outgoing calls.

If we just do not use the Dialer UI when the permission is not granted,
it is at most a minor annoyance for the first time. After the user has
accepted an incoming call even just once, the permission will be
granted, and the Dialer integration will start to work just fine.

src/cheogram/java/com/cheogram/android/ConnectionService.java

@@ -117,9 +117,9 @@ public class ConnectionService extends android.telecom.ConnectionService {
 
 		PermissionManager permissionManager = PermissionManager.getInstance(this);
 		permissionManager.setNotificationSettings(
-			new NotificationSettings.Builder()
+				new NotificationSettings.Builder()
-				.withMessage(R.string.microphone_permission_for_call)
+						.withMessage(R.string.microphone_permission_for_call)
-				.withSmallIcon(R.drawable.ic_notification).build()
+						.withSmallIcon(R.drawable.ic_notification).build()
 		);
 
 		Set<String> permissions = new HashSet<>();
@@ -166,8 +166,8 @@ public class ConnectionService extends android.telecom.ConnectionService {
 		CheogramConnection connection = new CheogramConnection(account, with, null);
 		connection.setSessionId(sessionId);
 		connection.setAddress(
-			Uri.fromParts("tel", with.getLocal(), null),
+				Uri.fromParts("tel", with.getLocal(), null),
-			TelecomManager.PRESENTATION_ALLOWED
+				TelecomManager.PRESENTATION_ALLOWED
 		);
 		connection.setRinging();
 
@@ -269,7 +269,9 @@ public class ConnectionService extends android.telecom.ConnectionService {
 		public void onAnswer() {
 			// For incoming calls, a connection update may not have been triggered before answering
 			// so we have to acquire the rtp connection object here
-			this.rtpConnection = xmppConnectionService.getJingleConnectionManager().findJingleRtpConnection(account, with, sessionId);
+			this.rtpConnection =
+					xmppConnectionService.getJingleConnectionManager()
+							.findJingleRtpConnection(account, with, sessionId);
 
 			rtpConnection.get().acceptCall();
 		}

src/main/java/eu/siacs/conversations/services/NotificationService.java

@@ -444,14 +444,10 @@ public class NotificationService {
 
         PhoneAccountHandle handle = null;
         for (Contact contact : id.account.getRoster().getContacts()) {
-            if (!contact.getJid().getDomain().equals(id.with.getDomain())) {
+            if (!contact.getJid().getDomain().equals(id.with.getDomain()))
                 continue;
-            }
+            if (!contact.getPresences().anyIdentity("gateway", "pstn"))
-
-            if (!contact.getPresences().anyIdentity("gateway", "pstn")) {
                 continue;
-            }
-
             handle = contact.phoneAccountHandle();
             break;
         }