Compare commits

...

2 Commits

Author SHA1 Message Date
Peter Cai a631fae406 app_containers: Add TODO about DBus in userns 2022-12-31 15:56:56 -05:00
Peter Cai 1afb772f71 app_containers: Kill all previously running instances
Because things like dbus can be broken inside.
2022-12-31 15:56:09 -05:00
1 changed files with 6 additions and 0 deletions

View File

@ -29,6 +29,10 @@ if [ -f "$config" ]; then
source "$config"
fi
# Kill any previously running instances
# This could be due to, say, a broken libappindicator icon (because of broken dbus)
sudo -A machinectl kill $CONTAINER_NAME > /dev/null 2>&1
# Create a XDG_RUNTIME_DIR for guest on host
container_xdg_runtime="$(mktemp -d -p /var/tmp)"
trap cleanup EXIT
@ -75,6 +79,8 @@ if [ "$CONTAINER_USE_USERNS" = true ]; then
private_users=$(shuf -i 65536-$((2147483647 - 65536)) -n1) # Pick a random starting offset
bind_opts="idmap"
user_on_host=$((private_users + run_as))
# TODO: DBus is broken inside a user namespace due to permission issues
# TODO: Fix this, somehow.
fi
# Grant the user inside the container access to the Wayland / Xorg display