PeterCxy/irqbalance
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

irqbalance: initialize package_mask before using in do_one_cpu()

Browse source 
The local variable package_mask is used without initialized. add
cpus_clear(package_mask) before using, and move it to the error path
where getting packpage_mask fail from core_siblings.

In addition, the variable cache_mask is called cpu_set() twice, which
is unnecessary, so delete the redundant code.

Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
This commit is contained in:
Yunfeng Ye 2019-11-06 11:44:43 +08:00
parent 8799a564dc
commit 47137bb3e7
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cputree.c
View file

@ -299,12 +299,13 @@ static void do_one_cpu(char *path)
return;
}
cpu_set(cpu->number, package_mask);
/* try to read the package mask; if it doesn't exist assume solitary */
snprintf(new_path, ADJ_SIZE(path, "/topology/core_siblings"),
"%s/topology/core_siblings", path);
process_one_line(new_path, get_mask_from_bitmap, &package_mask);
if (process_one_line(new_path, get_mask_from_bitmap, &package_mask)) {
cpus_clear(package_mask);
cpu_set(cpu->number, package_mask);
}
/* try to read the package id */
snprintf(new_path, ADJ_SIZE(path, "/topology/physical_package_id"),
@ -313,7 +314,6 @@ static void do_one_cpu(char *path)
/* try to read the cache mask; if it doesn't exist assume solitary */
/* We want the deepest cache level available */
cpu_set(cpu->number, cache_mask);
max_cache_index = 0;
cache_index = 1;
do {