PeterCxy/irqbalance
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

numa: Reset unassigned node on tree rebuild

Browse source 
http://code.google.com/p/irqbalance/issues/detail?id=38

This issue noted that on a tree rebuild, the unassigned node has pointers to the
interrupt list and children list that is left over from the previous tree state.
We erroneously follow these lists even though they are no longer allocated,
leading to memory errors

Fix it my re-initializing to the startup state.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
This commit is contained in:
Neil Horman 2012-08-24 12:48:07 -04:00
parent 918c8a9da1
commit 5dfe1f8817
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
numa.c
View file

@ -38,7 +38,7 @@
GList *numa_nodes = NULL;
static struct topo_obj unspecified_node = {
static struct topo_obj unspecified_node_template = {
.load = 0,
.number = -1,
.obj_type = OBJ_TYPE_NODE,
@ -49,6 +49,8 @@ static struct topo_obj unspecified_node = {
.obj_type_list = &numa_nodes,
};
static struct topo_obj unspecified_node;
static void add_one_node(const char *nodename)
{
char path[PATH_MAX];
@ -85,6 +87,13 @@ void build_numa_node_list(void)
DIR *dir = opendir(SYSFS_NODE_PATH);
struct dirent *entry;
/*
* Note that we copy the unspcified node from the template here
* in the event we just freed the object tree during a rescan.
* This ensures we don't get stale list pointers anywhere
*/
memcpy(&unspecified_node, &unspecified_node_template, sizeof (struct topo_obj));
/*
* Add the unspecified node
*/