PeterCxy/irqbalance
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add strlen checking for IRQBALANCE_BANNED_CPUS

Browse source 
When the environment variable IRQBALANCE_BANNED_CPUS is not specifily
the cpu, we expect do not place IRQs on CPUs the kernel keeps isolated
or nohz_full.

But currently, it will go to call cpumask_parse_user and ignore the
isolated or nohz_full. so add strlen checking before calling
cpumask_parse_user.
This commit is contained in:
Yunfeng Ye 2020-07-24 09:48:57 +08:00
parent 98b0f905bc
commit 731429f207
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cputree.c
View file

@ -110,6 +110,7 @@ static void setup_banned_cpus(void)
char buffer[4096];
cpumask_t nohz_full;
cpumask_t isolated_cpus;
char *env = NULL;
cpus_clear(isolated_cpus);
cpus_clear(nohz_full);
@ -120,8 +121,9 @@ static void setup_banned_cpus(void)
strlen(banned_cpumask_from_ui), banned_cpus);
goto out;
}
if (getenv("IRQBALANCE_BANNED_CPUS")) {
cpumask_parse_user(getenv("IRQBALANCE_BANNED_CPUS"), strlen(getenv("IRQBALANCE_BANNED_CPUS")), banned_cpus);
env = getenv("IRQBALANCE_BANNED_CPUS");
if (env && strlen(env)) {
cpumask_parse_user(env, strlen(env), banned_cpus);
goto out;
}