diff --git a/cputree.c b/cputree.c index eed20db..fda0200 100644 --- a/cputree.c +++ b/cputree.c @@ -102,7 +102,7 @@ static void get_mask_from_cpulist(char *line, void *mask) /* * By default do not place IRQs on CPUs the kernel keeps isolated or * nohz_full, as specified through the boot commandline. Users can - * override this with the IRQBALANCE_BANNED_CPUS environment variable. + * override this with the IRQBALANCE_BANNED_CPULIST environment variable. */ static void setup_banned_cpus(void) { @@ -118,9 +118,20 @@ static void setup_banned_cpus(void) strlen(banned_cpumask_from_ui), banned_cpus); goto out; } + + /* + * Notes: + * The IRQBALANCE_BANNED_CPUS will be discarded, please use + * IRQBALANCE_BANNED_CPULIST instead. + * + * Before deleting this environment variable, Introduce a + * deprecation period first for the consider of compatibility. + */ env = getenv("IRQBALANCE_BANNED_CPUS"); if (env && strlen(env)) { cpumask_parse_user(env, strlen(env), banned_cpus); + log(TO_ALL, LOG_WARNING, + "IRQBALANCE_BANNED_CPUS is discarded, Use IRQBALANCE_BANNED_CPULIST instead\n"); goto out; } diff --git a/irqbalance.1 b/irqbalance.1 index fb96664..215f75a 100644 --- a/irqbalance.1 +++ b/irqbalance.1 @@ -163,7 +163,9 @@ processors, each group of eight hex digits is separated by a comma ’,’. i.e. to the 7th-12th cpus (cpu6-cpu11) or ‘export IRQBALANCE_BANNED_CPUS=ff000000,00000001‘ would prevent irqbalance from assigning irqs to the 1st (cpu0) and 57th-64th cpus (cpu56-cpu63). - +Notes: This environment variable will be discarded, please use IRQBALANCE_BANNED_CPULIST +instead. Before deleting this environment variable, Introduce a deprecation period first +for the consider of compatibility. .TP .B IRQBALANCE_BANNED_CPULIST