1189cd6f19
Serj Kalichev reported a problem with irqbalance on non-numa systems, indicating that irqs were not balanced because the placement algorithm ignores the unspecified node. We need to not do that, but only in cases where we don't have any other nodes. If we have a valid numa system, then we want to always choose one of the real nodes over the unspecified one, but in non-numa systems we can and should allow the selection of the unspecified (and only) node Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Reported-by: Serj Kalichev <serj.kalichev@gmail.com>
202 lines
4.9 KiB
C
202 lines
4.9 KiB
C
/*
|
|
* Copyright (C) 2006, Intel Corporation
|
|
*
|
|
* This file is part of irqbalance
|
|
*
|
|
* This program file is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program in a file named COPYING; if not, write to the
|
|
* Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA
|
|
*/
|
|
#include "config.h"
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <stdint.h>
|
|
|
|
#include "types.h"
|
|
#include "irqbalance.h"
|
|
|
|
|
|
int power_mode;
|
|
|
|
GList *rebalance_irq_list;
|
|
|
|
struct obj_placement {
|
|
struct topo_obj *best;
|
|
struct topo_obj *least_irqs;
|
|
uint64_t best_cost;
|
|
struct irq_info *info;
|
|
};
|
|
|
|
static void find_best_object(struct topo_obj *d, void *data)
|
|
{
|
|
struct obj_placement *best = (struct obj_placement *)data;
|
|
uint64_t newload;
|
|
cpumask_t subset;
|
|
|
|
/*
|
|
* Don't consider the unspecified numa node here
|
|
*/
|
|
if (numa_avail && (d->obj_type == OBJ_TYPE_NODE) && (d->number == -1))
|
|
return;
|
|
|
|
/*
|
|
* If the hint policy is subset, then we only want
|
|
* to consider objects that are within the irqs hint, but
|
|
* only if that irq in fact has published a hint
|
|
*/
|
|
if (hint_policy == HINT_POLICY_SUBSET) {
|
|
if (!cpus_empty(best->info->affinity_hint)) {
|
|
cpus_and(subset, best->info->affinity_hint, d->mask);
|
|
if (cpus_empty(subset))
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (d->powersave_mode)
|
|
return;
|
|
|
|
newload = d->load;
|
|
if (newload < best->best_cost) {
|
|
best->best = d;
|
|
best->best_cost = newload;
|
|
best->least_irqs = NULL;
|
|
}
|
|
|
|
if (newload == best->best_cost) {
|
|
if (g_list_length(d->interrupts) < g_list_length(best->best->interrupts))
|
|
best->least_irqs = d;
|
|
}
|
|
}
|
|
|
|
static void find_best_object_for_irq(struct irq_info *info, void *data)
|
|
{
|
|
struct obj_placement place;
|
|
struct topo_obj *d = data;
|
|
struct topo_obj *asign;
|
|
|
|
if (!info->moved)
|
|
return;
|
|
|
|
switch (d->obj_type) {
|
|
case OBJ_TYPE_NODE:
|
|
if (info->level == BALANCE_NONE)
|
|
return;
|
|
break;
|
|
|
|
case OBJ_TYPE_PACKAGE:
|
|
if (info->level == BALANCE_PACKAGE)
|
|
return;
|
|
break;
|
|
|
|
case OBJ_TYPE_CACHE:
|
|
if (info->level == BALANCE_CACHE)
|
|
return;
|
|
break;
|
|
|
|
case OBJ_TYPE_CPU:
|
|
if (info->level == BALANCE_CORE)
|
|
return;
|
|
break;
|
|
}
|
|
|
|
place.info = info;
|
|
place.best = NULL;
|
|
place.least_irqs = NULL;
|
|
place.best_cost = INT_MAX;
|
|
|
|
for_each_object(d->children, find_best_object, &place);
|
|
|
|
asign = place.least_irqs ? place.least_irqs : place.best;
|
|
|
|
if (asign) {
|
|
migrate_irq(&d->interrupts, &asign->interrupts, info);
|
|
info->assigned_obj = asign;
|
|
asign->load += info->load;
|
|
}
|
|
}
|
|
|
|
static void place_irq_in_object(struct topo_obj *d, void *data __attribute__((unused)))
|
|
{
|
|
if (g_list_length(d->interrupts) > 0)
|
|
for_each_irq(d->interrupts, find_best_object_for_irq, d);
|
|
}
|
|
|
|
static void place_irq_in_node(struct irq_info *info, void *data __attribute__((unused)))
|
|
{
|
|
struct obj_placement place;
|
|
struct topo_obj *asign;
|
|
|
|
if( info->level == BALANCE_NONE)
|
|
return;
|
|
|
|
if (irq_numa_node(info)->number != -1) {
|
|
/*
|
|
* This irq belongs to a device with a preferred numa node
|
|
* put it on that node
|
|
*/
|
|
migrate_irq(&rebalance_irq_list, &irq_numa_node(info)->interrupts, info);
|
|
info->assigned_obj = irq_numa_node(info);
|
|
irq_numa_node(info)->load += info->load + 1;
|
|
return;
|
|
}
|
|
|
|
place.best_cost = INT_MAX;
|
|
place.best = NULL;
|
|
place.least_irqs = NULL;
|
|
place.info = info;
|
|
|
|
for_each_object(numa_nodes, find_best_object, &place);
|
|
|
|
asign = place.least_irqs ? place.least_irqs : place.best;
|
|
|
|
if (asign) {
|
|
migrate_irq(&rebalance_irq_list, &asign->interrupts, info);
|
|
info->assigned_obj = asign;
|
|
asign->load += info->load;
|
|
}
|
|
}
|
|
|
|
static void validate_irq(struct irq_info *info, void *data)
|
|
{
|
|
if (info->assigned_obj != data)
|
|
printf("object validation error: irq %d is wrong, points to %p, should be %p\n",
|
|
info->irq, info->assigned_obj, data);
|
|
}
|
|
|
|
static void validate_object(struct topo_obj *d, void *data __attribute__((unused)))
|
|
{
|
|
if (g_list_length(d->interrupts) > 0)
|
|
for_each_irq(d->interrupts, validate_irq, d);
|
|
}
|
|
|
|
static void validate_object_tree_placement(void)
|
|
{
|
|
for_each_object(packages, validate_object, NULL);
|
|
for_each_object(cache_domains, validate_object, NULL);
|
|
for_each_object(cpus, validate_object, NULL);
|
|
}
|
|
|
|
void calculate_placement(void)
|
|
{
|
|
sort_irq_list(&rebalance_irq_list);
|
|
if (g_list_length(rebalance_irq_list) > 0) {
|
|
for_each_irq(rebalance_irq_list, place_irq_in_node, NULL);
|
|
for_each_object(numa_nodes, place_irq_in_object, NULL);
|
|
for_each_object(packages, place_irq_in_object, NULL);
|
|
for_each_object(cache_domains, place_irq_in_object, NULL);
|
|
}
|
|
if (debug_mode)
|
|
validate_object_tree_placement();
|
|
}
|