fix: filter plugins should have access to idService in order to calculate account age

A new field `noteFilterPlugin` is added to `config.yml` which should
point to a JavaScript ES Module file containing a default export of the
following:

```
export default async function (context) {
    return { verdict: false };
}
```

where the function is expected to take a `context` object (see
`NoteCreateService.ts` for what this object contains) and return a
result of two fields: `verdict` and `reason`. If `verdict` is set to
true, the note contained within the `context` object will be blocked
from the local instance.

CHANGELOG.md

@@ -641,7 +641,6 @@
 - nsfwjs のモデルロードを排他することで、重複ロードによってメモリ使用量が増加しないように
 - 連合の配送ジョブのパフォーマンスを向上（ロック機構の見直し、Redisキャッシュの活用）
 - featuredノートのsignedGet回数を減らしました
-- ActivityPubの署名用鍵長を2048bitに変更しパフォーマンスを向上(新規アカウントのみ)
 - リモートサーバーのセンシティブなファイルのキャッシュだけを無効化できるオプションを追加
 - MeilisearchにIndexするノートの範囲を設定できるように
 - Export notes with file detail

packages/backend/src/config.ts

@@ -93,6 +93,10 @@ type Source = {
 	perUserNotificationsMaxCount?: number;
 	deactivateAntennaThreshold?: number;
 	pidFile: string;
+
+	// BEGIN comfy.social
+	noteFilterPlugin?: string;
+	// END comfy.social
 };
 
 export type Config = {
@@ -170,6 +174,10 @@ export type Config = {
 	perUserNotificationsMaxCount: number;
 	deactivateAntennaThreshold: number;
 	pidFile: string;
+
+	// BEGIN comfy.social
+	noteFilterPlugin?: string;
+	// END comfy.social
 };
 
 const _filename = fileURLToPath(import.meta.url);
@@ -265,6 +273,9 @@ export function loadConfig(): Config {
 		perUserNotificationsMaxCount: config.perUserNotificationsMaxCount ?? 500,
 		deactivateAntennaThreshold: config.deactivateAntennaThreshold ?? (1000 * 60 * 60 * 24 * 7),
 		pidFile: config.pidFile,
+		// BEGIN comfy.social
+		noteFilterPlugin: config.noteFilterPlugin,
+		// END comfy.social
 	};
 }
 

packages/backend/src/core/CreateSystemUserService.ts

@@ -38,7 +38,7 @@ export class CreateSystemUserService {
 		// Generate secret
 		const secret = generateNativeUserToken();
 
-		const keyPair = await genRsaKeyPair();
+		const keyPair = await genRsaKeyPair(4096);
 
 		let account!: MiUser;
 

packages/backend/src/core/NoteCreateService.ts

@@ -147,11 +147,29 @@ type Option = {
 	app?: MiApp | null;
 };
 
+// BEGIN comfy.social
+type NoteFilterResult = {
+	verdict: boolean; // true = block
+	reason?: string;
+};
+
+type NoteFilterPluginContext = {
+	data: Option;
+	user: MiUser;
+	mentionedUsers: MiUser[];
+	remoteUserResolveService: RemoteUserResolveService;
+	idService: IdService;
+}
+// END comfy.social
+
 @Injectable()
 export class NoteCreateService implements OnApplicationShutdown {
 	#shutdownController = new AbortController();
 
 	public static ContainsProhibitedWordsError = class extends Error {};
+	// BEGIN comfy.social
+	private noteFilterPluginFn?: (context: NoteFilterPluginContext) => Promise<NoteFilterResult> = null;
+	// END comfy.social
 
 	constructor(
 		@Inject(DI.config)
@@ -219,7 +237,15 @@ export class NoteCreateService implements OnApplicationShutdown {
 		private instanceChart: InstanceChart,
 		private utilityService: UtilityService,
 		private userBlockingService: UserBlockingService,
-	) { }
+	) {
+		// BEGIN comfy.social
+		if (this.config.noteFilterPlugin != null) {
+			import(this.config.noteFilterPlugin).then((m) => {
+				this.noteFilterPluginFn = m.default;
+			});
+		}
+		// END comfy.social
+	}
 
 	@bindThis
 	public async create(user: {
@@ -379,6 +405,23 @@ export class NoteCreateService implements OnApplicationShutdown {
 			}
 		}
 
+		// BEGIN comfy.social
+		// Invoke customizable filter policy
+		if (this.noteFilterPluginFn != null) {
+			const filterResult = await this.noteFilterPluginFn({
+				data: data,
+				user: user,
+				mentionedUsers: mentionedUsers,
+				remoteUserResolveService: this.remoteUserResolveService,
+				idService: this.idService,
+			});
+
+			if (filterResult.verdict) {
+				throw new Error(`Blocked by custom filter policy, reason: ${filterResult.reason}`);
+			}
+		}
+		// END comfy.social
+
 		const note = await this.insertNote(user, data, tags, emojis, mentionedUsers);
 
 		setImmediate('post created', { signal: this.#shutdownController.signal }).then(

packages/backend/src/core/SignupService.ts

@@ -95,7 +95,7 @@ export class SignupService {
 
 		const keyPair = await new Promise<string[]>((res, rej) =>
 			generateKeyPair('rsa', {
-				modulusLength: 2048,
+				modulusLength: 4096,
 				publicKeyEncoding: {
 					type: 'spki',
 					format: 'pem',