From 0ca314e7f955f01c8464c0a6b09a8e905ea219d2 Mon Sep 17 00:00:00 2001 From: Christian Hagau Date: Wed, 22 Nov 2017 00:00:00 +0000 Subject: [PATCH] Cosmetic improvements to SshAuthenticationApi --- .../authentication/SshAuthenticationApi.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sshauthentication-api/src/main/java/org/openintents/ssh/authentication/SshAuthenticationApi.java b/sshauthentication-api/src/main/java/org/openintents/ssh/authentication/SshAuthenticationApi.java index adce16718..f7d248ff2 100644 --- a/sshauthentication-api/src/main/java/org/openintents/ssh/authentication/SshAuthenticationApi.java +++ b/sshauthentication-api/src/main/java/org/openintents/ssh/authentication/SshAuthenticationApi.java @@ -149,22 +149,22 @@ public class SshAuthenticationApi { void onReturn(final Intent result); } - private class SshAgentAsyncTask extends AsyncTask { - Intent data; - ISshAgentCallback callback; + private class SshAgentAsyncTask extends AsyncTask { + Intent mRequest; + ISshAgentCallback mCallback; - private SshAgentAsyncTask(Intent data, ISshAgentCallback callback) { - this.data = data; - this.callback = callback; + private SshAgentAsyncTask(Intent request, ISshAgentCallback callback) { + mRequest = request; + mCallback = callback; } @Override protected Intent doInBackground(Void... unused) { - return executeApi(data); + return executeApi(mRequest); } protected void onPostExecute(Intent result) { - callback.onReturn(result); + mCallback.onReturn(result); } } @@ -176,9 +176,9 @@ public class SshAuthenticationApi { // don't serialize async tasks, always execute them in parallel // http://commonsware.com/blog/2012/04/20/asynctask-threading-regression-confirmed.html if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) { - task.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, (Void[]) null); + task.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR); } else { - task.execute((Void[]) null); + task.execute(); } }