0.8.x branch promoted to version 0.8.1, fixed list view of mail accounts not filling the main layout, made a bunch of private classes static

AndroidManifest.xml

@@ -16,7 +16,7 @@
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
       package="org.thialfihar.android.apg"
-      android:versionCode="3" android:versionName="0.8.0">
+      android:versionName="0.8.1" android:versionCode="4">
     <application android:icon="@drawable/icon" android:label="@string/app_name">
         <activity android:name=".MainActivity"
                   android:label="@string/app_name"

res/layout/main.xml

@@ -26,12 +26,13 @@
    android:layout_marginTop="10dip"
    android:layout_width="fill_parent"
    android:layout_height="0dip"
-   android:layout_weight="1">
+   android:layout_weight="1"
+   android:fillViewport="true">
 
 <ListView
    android:id="@+id/account_list"
    android:layout_width="fill_parent"
-   android:layout_height="wrap_content">
+   android:layout_height="fill_parent">
 </ListView>
 
 </ScrollView>

src/org/thialfihar/android/apg/Apg.java

@@ -97,7 +97,7 @@ public class Apg {
         public static final String ENCRYPT = "org.thialfihar.android.apg.intent.ENCRYPT";
     }
 
-    public static String VERSION = "0.8.0";
+    public static String VERSION = "0.8.1";
     public static String FULL_VERSION = "APG v" + VERSION;
 
     private static final int[] PREFERRED_SYMMETRIC_ALGORITHMS =

src/org/thialfihar/android/apg/MailListActivity.java

@@ -39,7 +39,7 @@ import android.widget.AdapterView.OnItemClickListener;
 public class MailListActivity extends ListActivity {
     LayoutInflater minflater = null;
 
-    private class Conversation {
+    private static class Conversation {
         public long id;
         public String subject;
         public Vector<Message> messages;
@@ -50,7 +50,7 @@ public class MailListActivity extends ListActivity {
         }
     }
 
-    private class Message {
+    private static class Message {
         public Conversation parent;
         public long id;
         public String subject;

src/org/thialfihar/android/apg/MainActivity.java

@@ -360,7 +360,7 @@ public class MainActivity extends Activity {
         startActivity(new Intent(this, MailListActivity.class).putExtra("account", account));
     }
 
-    private class AccountListAdapter extends CursorAdapter {
+    private static class AccountListAdapter extends CursorAdapter {
         private LayoutInflater minflater;
 
         public AccountListAdapter(Context context, Cursor cursor) {

src/org/thialfihar/android/apg/PublicKeyListActivity.java

@@ -481,7 +481,7 @@ public class PublicKeyListActivity extends ExpandableListActivity
         ((PublicKeyListAdapter) getExpandableListAdapter()).notifyDataSetChanged();
     }
 
-    private class PublicKeyListAdapter extends BaseExpandableListAdapter {
+    private static class PublicKeyListAdapter extends BaseExpandableListAdapter {
         private LayoutInflater mInflater;
 
         private class KeyChild {

src/org/thialfihar/android/apg/SecretKeyListActivity.java

@@ -580,7 +580,7 @@ public class SecretKeyListActivity extends ExpandableListActivity
                 .notifyDataSetChanged();
     }
 
-    private class SecretKeyListAdapter extends BaseExpandableListAdapter {
+    private static class SecretKeyListAdapter extends BaseExpandableListAdapter {
         private LayoutInflater mInflater;
 
         private class KeyChild {

src/org/thialfihar/android/apg/provider/DataProvider.java

@@ -115,14 +115,7 @@ public class DataProvider extends ContentProvider {
 
         @Override
         public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
-            int currentVersion = oldVersion;
-            while (currentVersion < newVersion) {
-                switch (currentVersion) {
-                    default: {
-                        break;
-                    }
-                }
-            }
+            // TODO: upgrade db if necessary, and do that in a clever way
         }
     }