From bccc20ea322ab0ef35f8f115e2f9bc0a92897ae8 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 19 Jan 2018 17:58:34 +0100 Subject: [PATCH] Reduce max apdu length, for compatibility --- .../keychain/securitytoken/OpenPgpCommandApduFactory.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/OpenPgpCommandApduFactory.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/OpenPgpCommandApduFactory.java index 5fa4f93e9..c3a364e1a 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/OpenPgpCommandApduFactory.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/securitytoken/OpenPgpCommandApduFactory.java @@ -28,7 +28,9 @@ import org.bouncycastle.util.encoders.Hex; public class OpenPgpCommandApduFactory { - private static final int MAX_APDU_NC = 255; + // The spec allows 255, but for compatibility with non-compliant tokens we use 254 here + // See https://github.com/open-keychain/open-keychain/issues/2049 + private static final int MAX_APDU_NC = 254; private static final int MAX_APDU_NC_EXT = 65535; private static final int MAX_APDU_NE = 256;