From edaa629f4699ca5b5bdca731c215f9feb4666dca Mon Sep 17 00:00:00 2001
From: Vincent Breitmoser <look@my.amazin.horse>
Date: Fri, 13 Oct 2017 18:42:41 +0200
Subject: [PATCH] add unit tests for CommandApdu

---
 .../securitytoken/CommandApduTest.java        | 102 ++++++++++++++++++
 1 file changed, 102 insertions(+)
 create mode 100644 OpenKeychain/src/test/java/org/sufficientlysecure/keychain/securitytoken/CommandApduTest.java

diff --git a/OpenKeychain/src/test/java/org/sufficientlysecure/keychain/securitytoken/CommandApduTest.java b/OpenKeychain/src/test/java/org/sufficientlysecure/keychain/securitytoken/CommandApduTest.java
new file mode 100644
index 000000000..d77dfa24c
--- /dev/null
+++ b/OpenKeychain/src/test/java/org/sufficientlysecure/keychain/securitytoken/CommandApduTest.java
@@ -0,0 +1,102 @@
+package org.sufficientlysecure.keychain.securitytoken;
+
+
+import org.bouncycastle.util.encoders.Hex;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.sufficientlysecure.keychain.KeychainTestRunner;
+
+import static junit.framework.Assert.assertEquals;
+import static org.junit.Assert.assertArrayEquals;
+
+
+@SuppressWarnings("WeakerAccess")
+@RunWith(KeychainTestRunner.class)
+public class CommandApduTest {
+    static final byte[] DATA_LONG = new byte[500];
+    static final byte[] DATA_SHORT = { 1, 2, 3 };
+    static final int CLA = 1;
+    static final int INS = 2;
+    static final int P1 = 3;
+    static final int P2 = 4;
+    static final int NE_SHORT = 5;
+    static final int NE_LONG = 500;
+    static final int NE_SPECIAL = 256;
+
+    @Test
+    public void testCase1() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase2s() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, NE_SHORT);
+
+        assertEquals(5, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase2e() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, NE_LONG);
+
+        assertEquals(7, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase2e_specialNe() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, NE_SPECIAL);
+
+        assertEquals(5, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase3s() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, DATA_SHORT);
+
+        assertEquals(4 + 1 + DATA_SHORT.length, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase3e() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, DATA_LONG);
+
+        assertEquals(4 + 3 + DATA_LONG.length, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase4s() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, DATA_SHORT, 5);
+
+        assertArrayEquals(Hex.decode("010203040301020305"), commandApdu.toBytes());
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    @Test
+    public void testCase4e() throws Exception {
+        CommandApdu commandApdu = CommandApdu.create(CLA, INS, P1, P2, DATA_LONG, 5);
+
+        assertEquals(4 + 5 + DATA_LONG.length, commandApdu.toBytes().length);
+
+        assertParsesCorrectly(commandApdu);
+    }
+
+    private void assertParsesCorrectly(CommandApdu commandApdu) {
+        byte[] bytes = commandApdu.toBytes();
+        CommandApdu parsedCommandApdu = CommandApdu.fromBytes(bytes);
+        assertEquals(commandApdu, parsedCommandApdu);
+    }
+}
\ No newline at end of file