From fd9b1310b07dc14c7de117b5f61143b6bf206b09 Mon Sep 17 00:00:00 2001
From: Peter Cai <peter@typeblog.net>
Date: Fri, 21 Feb 2020 16:25:57 +0800
Subject: [PATCH] api: retry twice for insert

---
 src/api.rs | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/api.rs b/src/api.rs
index f651368..8295a8b 100644
--- a/src/api.rs
+++ b/src/api.rs
@@ -174,10 +174,15 @@ fn items_sync(db: DbConn, u: user::User, params: Json<SyncParams>) -> Custom<Jso
     // First, update all items sent by client
     for it in inner_params.items.into_iter() {
         if let Err(item::ItemOpError(_)) = item::SyncItem::items_insert(&db, &u, &it) {
-            // Let's not fail just because one of them...
-            // At least the client will know there's an error
-            // (maybe mistakes it for conflict)
-            resp.unsaved.push(it);
+            // Well, we should try twice...
+            // TODO: make this more elegant (also handle differneces between db error and conflict)
+            // (if we were ever to implement a conflict feature)
+            if let Err(item::ItemOpError(_)) = item::SyncItem::items_insert(&db, &u, &it) {
+                // Let's not fail just because one of them...
+                // At least the client will know there's an error
+                // (maybe mistakes it for conflict)
+                resp.unsaved.push(it);
+            }
         } else {
             resp.saved_items.push(it);
         }