PeterGSI/android_packages_apps_QcRilAm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Compare commits

base: PeterGSI:018a53aa501fc386debdc9bdeb9ddaaada8c8c73
Branches Tags
PeterGSI:master
PeterGSI:aosp14
...
compare: PeterGSI:82eee5814b928f6b30ae1e1a52e3bd727a381ca9
Branches Tags
PeterGSI:aosp14
PeterGSI:master

5 commits
018a53aa50 ... 82eee5814b

Author SHA1 Message Date
Peter Cai
82eee5814b Android.bp: correct HIDL path 2022-11-07 22:15:15 -05:00
Alin Jerpelea
ef51ec65f5
Merge pull request #8 from ix5/getservice-retry 
QcRilAmService: Wait for IQcRilAudio to be up
 2020-05-27 10:52:06 +02:00
ix5
331833e6b6 QcRilAmService: Wait for IQcRilAudio to be up 
The default call to getService of a HIDL/AIDL interface will
not wait for the service to be up. Use the retry parameter
to use tryGetService internally.

This will fix a deprecation warning on future Android versions.

See https://android-review.googlesource.com/c/platform/system/tools/hidl/+/1291900
 2020-05-26 19:51:39 +02:00
Alin Jerpelea
3dcbcf185d
Merge pull request #7 from MarijnS95/remove-shared-user-id 
[QCRILAM] Remove sharedUserId
 2020-05-24 13:41:35 +02:00
MarijnS95
00dcbd7f57 Remove unnecessary, deprecated sharedUserId with system 
sharedUserId is a deprecated flag [1] that muddies the waters when it
comes to enforcement of various policies and permissions. QcRilAm
doesn't use any and operates just fine within normal app boundaries
(uses public APIs, doesn't need any permissions outside "normal" ones,
and accesses vendor services properly over Binder).
This also allows the signing key to differ from platform, where other
android.uid.system apps are signed with.

[1] https://developer.android.com/guide/topics/manifest/manifest-element#uid

Signed-off-by: MarijnS95 <marijns95@gmail.com>
 2020-05-22 18:03:04 +02:00
3 changed files with 2 additions and 3 deletions
Show stats Expand all files Collapse all files

2
Android.bp
View file

@ -4,7 +4,7 @@ subdirs = [
hidl_package_root { hidl_package_root {
name: "vendor.qti.hardware.radio.am", name: "vendor.qti.hardware.radio.am",
path: "vendor/oss/qcrilam/interface/am", path: "packages/apps/QcRilAm/interface/am",
} }
android_app { android_app {

1
AndroidManifest.xml
View file

@ -2,7 +2,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" <manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.sony.qcrilam" package="com.sony.qcrilam"
coreApp="true" coreApp="true"
android:sharedUserId="android.uid.system"
android:versionCode="1" android:versionCode="1"
android:versionName="1.0" > android:versionName="1.0" >

2
src/com/sony/qcrilam/QcRilAmService.kt
View file

@ -35,7 +35,7 @@ private const val TAG = "QcRilAm-Service"
class QcRilAmService : Service() { class QcRilAmService : Service() {
private fun addCallbackForSimSlot(simSlotNo: Int, audioManager: AudioManager) { private fun addCallbackForSimSlot(simSlotNo: Int, audioManager: AudioManager) {
try { try {
val qcRilAudio = IQcRilAudio.getService("slot$simSlotNo") val qcRilAudio = IQcRilAudio.getService("slot$simSlotNo", true /*retry*/)
if (qcRilAudio == null) { if (qcRilAudio == null) {
Log.e(TAG, "Could not get service instance for slot$simSlotNo, failing") Log.e(TAG, "Could not get service instance for slot$simSlotNo, failing")
} else { } else {