mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-09-07 15:31:16 +02:00
Set max text height to prevent overflow (#18862)
Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button. Before: ![image](https://user-images.githubusercontent.com/12700993/155253001-e1dab086-aaf3-4338-889d-6a861728274a.png) After: ![image](https://user-images.githubusercontent.com/12700993/155253144-5b9a3547-9582-412f-867f-41a45a14a0fe.png) Interestingly, I don't see this bug on Firefox.
This commit is contained in:
parent
2b9df564b8
commit
f7085f718b
|
@ -462,7 +462,7 @@ export function initRepoPullRequestReview() {
|
|||
(async () => {
|
||||
// the editor's height is too large in some cases, and the panel cannot be scrolled with page now because there is `.repository .diff-detail-box.sticky { position: sticky; }`
|
||||
// the temporary solution is to make the editor's height smaller (about 4 lines). GitHub also only show 4 lines for default. We can improve the UI (including Dropzone area) in future
|
||||
await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px'});
|
||||
await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px', maxHeight: 'calc(100vh - 360px)'});
|
||||
initCompImagePaste($reviewBox);
|
||||
})();
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue