From f7ede92f82f7f3ec7bb31a1249f9524e5b728f34 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 10 May 2023 23:59:58 +0200 Subject: [PATCH] Notification list enhancements, fix striped tables on dark theme (#24639) - Make code block rendering via backticks work - Remove link color unless hovered - Remove table stripes and fix stripes rendering on dark theme for other tables - Introduce new `button-link` class discussed previously for buttons that look and act like links and apply it to the two right-side buttons - Reduce box padding by 8px on each side - Fix "Mark all read" button margin-right - brighten `--color-markup-code-block` on arc-green ### Before Screenshot 2023-05-10 at 20 00 30 Screenshot 2023-05-10 at 20 00 48 ### After Screenshot 2023-05-10 at 20 09 59 Screenshot 2023-05-10 at 20 05 34 --- templates/repo/issue/list.tmpl | 4 ++-- templates/repo/issue/milestone_issues.tmpl | 6 +++--- templates/user/dashboard/navbar.tmpl | 2 +- .../user/notification/notification_div.tmpl | 20 +++++++++---------- web_src/css/base.css | 16 +++++++++++++++ web_src/css/helpers.css | 8 ++++++++ web_src/css/themes/theme-arc-green.css | 2 +- 7 files changed, 41 insertions(+), 17 deletions(-) diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index a7311c2490..d739561d27 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -215,9 +215,9 @@ {{if not .Repository.IsArchived}} {{if .IsShowClosed}} - + {{else}} - + {{end}}
diff --git a/templates/repo/issue/milestone_issues.tmpl b/templates/repo/issue/milestone_issues.tmpl index a1fc245887..82d2cac943 100644 --- a/templates/repo/issue/milestone_issues.tmpl +++ b/templates/repo/issue/milestone_issues.tmpl @@ -51,7 +51,7 @@
-
+
{{.locale.Tr "repo.issues.filter_label"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} @@ -153,9 +153,9 @@
{{if .IsShowClosed}} - + {{else}} - + {{end}}
diff --git a/templates/user/dashboard/navbar.tmpl b/templates/user/dashboard/navbar.tmpl index 7703bbfb98..20b66b2ec3 100644 --- a/templates/user/dashboard/navbar.tmpl +++ b/templates/user/dashboard/navbar.tmpl @@ -78,7 +78,7 @@ {{if .ContextUser.IsOrganization}}
- + {{svg "octicon-rss"}} {{.locale.Tr "activities"}} {{if not .UnitIssuesGlobalDisabled}} diff --git a/templates/user/notification/notification_div.tmpl b/templates/user/notification/notification_div.tmpl index 1ea34fe2a6..b8efd2433e 100644 --- a/templates/user/notification/notification_div.tmpl +++ b/templates/user/notification/notification_div.tmpl @@ -11,17 +11,17 @@ {{.locale.Tr "notification.read"}} {{if and (eq .Status 1)}} -
+ {{$.CsrfTokenHtml}}
-
{{end}}
-
+
{{if eq (len .Notifications) 0}} {{if eq .Status 1}} {{.locale.Tr "notification.no_unread"}} @@ -29,7 +29,7 @@ {{.locale.Tr "notification.no_read"}} {{end}} {{else}} - +
{{range $notification := .Notifications}} {{$issue := .Issue}} @@ -59,16 +59,16 @@ {{end}}
- + {{if $issue}} - #{{$issue.Index}} - {{$issue.Title}} + #{{$issue.Index}} - {{$issue.Title | RenderEmoji $.Context | RenderCodeBlock}} {{else}} {{$repo.FullName}} {{end}} - {{$repo.FullName}} + {{$repo.FullName}} {{if ne .Status 3}} @@ -76,7 +76,7 @@ {{$.CsrfTokenHtml}} -