forgejo/modules/markup/renderer_test.go
Earl Warren debf12f6c5 fix: markup rendering panic must not abort the process (#9478)
It must return on error instead, and log a stack trace for forensic analysis.

Refs https://codeberg.org/forgejo/forgejo/issues/9472

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests

- I added test coverage for Go changes...
  - [x] in their respective `*_test.go` for unit tests.
  - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
  - [ ] in `web_src/js/*.test.js` if it can be unit tested.
  - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [x] I do not want this change to show in the release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9478
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-09-30 09:39:34 +02:00

49 lines
1.3 KiB
Go

// Copyright 2025 The Forgejo Authors. All rights reserved.
// SPDX-License-Identifier: GPL-3.0-or-later
package markup
import (
"bytes"
"errors"
"strings"
"testing"
"forgejo.org/modules/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
type failReader struct{}
func (*failReader) Read(p []byte) (n int, err error) {
return 0, errors.New("FAIL")
}
func TestRender_postProcessOrCopy(t *testing.T) {
renderContext := &RenderContext{Ctx: t.Context()}
t.Run("CopyOK", func(t *testing.T) {
input := "SOMETHING"
output := &bytes.Buffer{}
require.NoError(t, postProcessOrCopy(renderContext, nil, strings.NewReader(input), output))
assert.Equal(t, input, output.String())
})
renderer := GetRendererByType("markdown")
t.Run("PostProcessOK", func(t *testing.T) {
input := "SOMETHING"
output := &bytes.Buffer{}
defer test.MockVariableValue(&defaultProcessors, []processor{})()
require.NoError(t, postProcessOrCopy(renderContext, renderer, strings.NewReader(input), output))
assert.Equal(t, input, output.String())
})
t.Run("PostProcessError", func(t *testing.T) {
input := &failReader{}
defer test.MockVariableValue(&defaultProcessors, []processor{})()
assert.ErrorContains(t, postProcessOrCopy(renderContext, renderer, input, &bytes.Buffer{}), "FAIL")
})
}