mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-10-19 00:30:46 +02:00
debf12f6c5
It must return on error instead, and log a stack trace for forensic analysis. Refs https://codeberg.org/forgejo/forgejo/issues/9472 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9478 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org> |
||
|---|---|---|
| .. | ||
| donotpanic | ||
| filebuffer | ||
| rotatingfilewriter | ||
| color.go | ||
| color_test.go | ||
| error.go | ||
| file_unix.go | ||
| file_unix_test.go | ||
| io.go | ||
| keypair.go | ||
| keypair_test.go | ||
| legacy.go | ||
| legacy_test.go | ||
| pack.go | ||
| pack_test.go | ||
| paginate.go | ||
| paginate_test.go | ||
| path.go | ||
| path_test.go | ||
| remove.go | ||
| sanitize.go | ||
| sanitize_test.go | ||
| sec_to_time.go | ||
| sec_to_time_test.go | ||
| shellquote.go | ||
| shellquote_test.go | ||
| slice.go | ||
| slice_test.go | ||
| string.go | ||
| string_test.go | ||
| timer.go | ||
| timer_test.go | ||
| truncate.go | ||
| truncate_test.go | ||
| url.go | ||
| util.go | ||
| util_test.go | ||