mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-10-21 07:10:39 +02:00
906e2e7c4a
When making a `POST` to start a workflow dispatch, and not specifying the option `"return_run_info": true`, the API handler attempts to render a `nil` as a JSON body to a `204 No Content` response. This results in an error being logged to the console, as this status code does not permit a body. ``` Render JSON failed: http: request method or response status code does not allow body ``` There is no functional impact except for a false error log, as `ctx.JSON` just logs a `Render JSON failed` error if it fails. I could not find any existing code which allows integration tests to intercept or inspect log output, which would be required for an automated test verifying this is fixed. If anyone could advise an existing test that performs log interception, or any hints on how such a mechanism would be created, I don't mind adding it... but it may not be warranted for such a tiny bug either. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9675 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net> |
||
|---|---|---|
| .. | ||
| action.go | ||
| avatar.go | ||
| blob.go | ||
| branch.go | ||
| collaborators.go | ||
| commits.go | ||
| compare.go | ||
| download.go | ||
| file.go | ||
| flags.go | ||
| fork.go | ||
| git_hook.go | ||
| git_ref.go | ||
| hook.go | ||
| hook_test.go | ||
| issue.go | ||
| issue_attachment.go | ||
| issue_comment.go | ||
| issue_comment_attachment.go | ||
| issue_dependency.go | ||
| issue_label.go | ||
| issue_pin.go | ||
| issue_reaction.go | ||
| issue_stopwatch.go | ||
| issue_subscription.go | ||
| issue_tracked_time.go | ||
| key.go | ||
| label.go | ||
| language.go | ||
| main_test.go | ||
| migrate.go | ||
| milestone.go | ||
| mirror.go | ||
| notes.go | ||
| patch.go | ||
| pull.go | ||
| pull_review.go | ||
| release.go | ||
| release_attachment.go | ||
| release_tags.go | ||
| repo.go | ||
| repo_test.go | ||
| star.go | ||
| status.go | ||
| subscriber.go | ||
| sync_fork.go | ||
| tag.go | ||
| tag_test.go | ||
| teams.go | ||
| topic.go | ||
| transfer.go | ||
| tree.go | ||
| wiki.go | ||