forgejo/tests/e2e/repo-files.test.e2e.ts
David Rotermund 957a76df3b feat: Drag and drop nested directories (#6687)
Adds the ability for the drag and drop file upload to handle subdirectories. You drag and drop and it preserves your sub-folder substructure. Nothing more, nothing less.

<!--start release-notes-assistant-->

## Release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- User Interface features
  - [PR](https://codeberg.org/forgejo/forgejo/pulls/6687): <!--number 6687 --><!--line 0 --><!--description RHJhZyBhbmQgZHJvcCBuZXN0ZWQgZGlyZWN0b3JpZXM=-->Drag and drop nested directories<!--description-->
<!--end release-notes-assistant-->

Co-authored-by: David Rotermund <davrot@neuro.uni-bremen.de>
Co-authored-by: Otto Richter <git@otto.splvs.net>
Co-authored-by: Beowulf <beowulf@beocode.eu>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6687
Reviewed-by: jerger <jerger@noreply.codeberg.org>
Co-authored-by: David Rotermund <davrot@noreply.codeberg.org>
Co-committed-by: David Rotermund <davrot@noreply.codeberg.org>
2025-10-03 00:16:40 +02:00

100 lines
3 KiB
TypeScript

// Copyright 2025 The Forgejo Authors. All rights reserved.
// SPDX-License-Identifier: MIT
// @watch start
// templates/repo/editor/**
// web_src/js/features/common-global.js
// routers/web/web.go
// services/repository/files/**
// @watch end
import {expect} from '@playwright/test';
import {test, dynamic_id} from './utils_e2e.ts';
test.use({user: 'user2'});
interface TestCase {
description: string;
files: string[];
}
async function doUpload({page}, testCase: TestCase) {
await page.goto(`/user2/file-uploads/_upload/main/`);
const testID = dynamic_id();
const dropzone = page.getByRole('button', {name: 'Drop files or click here to upload.'});
// create the virtual files
const dataTransfer = await page.evaluateHandle((testCase: TestCase) => {
const dt = new DataTransfer();
for (const filename of testCase.files) {
dt.items.add(new File([`File content of ${filename}`], filename, {type: 'text/plain'}));
}
return dt;
}, testCase);
// and drop them to the upload area
await dropzone.dispatchEvent('drop', {dataTransfer});
await page.getByText('new branch').click();
await page.getByRole('textbox', {name: 'Name the new branch for this'}).fill(testID);
// ToDo: Potential race condition: We do not currently wait for the upload to complete.
// See https://codeberg.org/forgejo/forgejo/pulls/6687#issuecomment-5068272 and
// https://codeberg.org/forgejo/forgejo/issues/5893#issuecomment-5068266 for details.
// Workaround is to wait (the uploads are just a few bytes and usually complete instantly)
//
// eslint-disable-next-line playwright/no-wait-for-timeout
await page.waitForTimeout(100);
await page.getByRole('button', {name: 'Propose file change'}).click();
}
test.describe('Drag and Drop upload', () => {
const goodTestCases: TestCase[] = [
{
description: 'normal and special characters',
files: [
'dir1/file1.txt',
'double/nested/file.txt',
'special/äüöÄÜÖß.txt',
'special/Ʉ₦ł₵ØĐɆ.txt',
],
},
{
description: 'strange paths and spaces',
files: [
'..dots.txt',
'.dots.preserved.txt',
'special/S P A C E !.txt',
],
},
];
// actual good tests based on definition above
for (const testCase of goodTestCases) {
test(`good: ${testCase.description}`, async ({page}) => {
await doUpload({page}, testCase);
// check that nested file structure is preserved
for (const filename of testCase.files) {
await expect(page.locator('#diff-file-boxes').getByRole('link', {name: filename})).toBeVisible();
}
});
}
const badTestCases: TestCase[] = [
{
description: 'broken path slash in front',
files: [
'/special/badfirstslash.txt',
],
},
];
// actual bad tests based on definition above
for (const testCase of badTestCases) {
test(`bad: ${testCase.description}`, async ({page}) => {
await doUpload({page}, testCase);
await expect(page.getByText('Failed to upload files to')).toBeVisible();
});
}
});