mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-09-17 03:23:01 +02:00
eb21dd17b8
Discovered a regression caused by #9017. Steps to reproduce: - Disable the forgejo-runner that will pick up a workflow - Trigger any workflow to run - Through the Actions list, click on the new workflow that is pending a runner to fetch it - You'll be redirected to /user/repo/actions/runs/73/jobs/0/attempt/0 (attempt = 0) - The UI will appear normal with the job "Waiting"... - Startup the forgejo-runner to pick up the workflow - The UI will begin to have errors: - JavaScript promise rejection: JSON.parse: unexpected keyword at line 1 column 1 of the JSON data. Open browser console to see more details. (5) The cause is that the redirect to `/attempt/0` occurs for a job that hasn't been started, but once the job is started attempt 0 is not a valid attempt and errors will occur when polling for data. This fix corrects the problem by redirecting to the attempt that will be present (attempt 1) when the job is fetched. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9293 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
145 lines
2.5 KiB
YAML
145 lines
2.5 KiB
YAML
-
|
|
id: 192
|
|
run_id: 791
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: c2d72f548424103f01ee1dc02889c1e2bff816b0
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 1
|
|
job_id: job_2
|
|
task_id: 47
|
|
status: 1
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 193
|
|
run_id: 792
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: c2d72f548424103f01ee1dc02889c1e2bff816b0
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 1
|
|
job_id: job_2
|
|
task_id: 48
|
|
status: 1
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 194
|
|
run_id: 793
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: c2d72f548424103f01ee1dc02889c1e2bff816b0
|
|
is_fork_pull_request: 0
|
|
name: job1 (1)
|
|
attempt: 1
|
|
job_id: job1
|
|
task_id: 49
|
|
status: 1
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 195
|
|
run_id: 793
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: c2d72f548424103f01ee1dc02889c1e2bff816b0
|
|
is_fork_pull_request: 0
|
|
name: job1 (2)
|
|
attempt: 1
|
|
job_id: job1
|
|
task_id: 50
|
|
status: 1
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 196
|
|
run_id: 793
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: c2d72f548424103f01ee1dc02889c1e2bff816b0
|
|
is_fork_pull_request: 0
|
|
name: job2
|
|
attempt: 1
|
|
job_id: job2
|
|
needs: [job1]
|
|
task_id: 51
|
|
status: 5
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 292
|
|
run_id: 891
|
|
repo_id: 1
|
|
owner_id: 1
|
|
commit_sha: 985f0301dba5e7b34be866819cd15ad3d8f508ee
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 1
|
|
job_id: job_2
|
|
task_id: 47
|
|
status: 1
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 393
|
|
run_id: 891
|
|
repo_id: 1
|
|
owner_id: 1
|
|
commit_sha: 985f0301dba5e7b34be866819cd15ad3d8f508ee
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 1
|
|
job_id: job_2
|
|
task_id: 47
|
|
status: 5
|
|
runs_on: '["ubuntu-latest"]'
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 394
|
|
run_id: 891
|
|
repo_id: 1
|
|
owner_id: 2
|
|
commit_sha: 985f0301dba5e7b34be866819cd15ad3d8f508ee
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 2
|
|
job_id: job_2
|
|
task_id: 47
|
|
status: 5
|
|
runs_on: '["debian-latest"]'
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 395
|
|
run_id: 891
|
|
repo_id: 1
|
|
owner_id: 3
|
|
commit_sha: 985f0301dba5e7b34be866819cd15ad3d8f508ee
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 1
|
|
job_id: job_2
|
|
task_id: 47
|
|
status: 5
|
|
runs_on: '["fedora"]'
|
|
started: 1683636528
|
|
stopped: 1683636626
|
|
-
|
|
id: 396
|
|
run_id: 794
|
|
repo_id: 4
|
|
owner_id: 1
|
|
commit_sha: 985f0301dba5e7b34be866819cd15ad3d8f508ee
|
|
is_fork_pull_request: 0
|
|
name: job_2
|
|
attempt: 0
|
|
job_id: job_2
|
|
task_id: null
|
|
status: 5
|
|
runs_on: '["fedora"]'
|
|
started: 1683636528
|
|
stopped: 1683636626
|