mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-09-17 03:23:01 +02:00
a082555c04
When you access Actions logs, there is a momentary render of a partially blank screen such as this:  This is caused by the `RepoActionView` Vue component having no data. It then performs a fetch to two APIs in parallel (shown here as `/0` and `/artifacts`) to retrieve the steps and artifacts for the action run, and then it renders the page. And then, even if the job is complete and the user hasn't yet interacted to expand any logs, it performs the same API calls a second time.  This PR fixes both problems by: - Injecting the initial data for the Action's steps & Artifacts into the initial page render, and using that data into the `RepoActionView` to serve as its initial data load. - No longer unconditionally starting a second invocation of `loadJob` 1 second later, as the initial data can be used to determine whether the job is still running and requires an interval refresh. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests **WIP** - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [x] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - User Interface bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/9099): <!--number 9099 --><!--line 0 --><!--description cHJldmVudCBpbml0aWFsICdibGFuaycgZGlzcGxheSBvZiBhY3Rpb24gbG9ncyB2aWV3LCByZW1vdmUgdW5uZWNlc3NhcnkgQVBJIGNhbGxz-->prevent initial 'blank' display of action logs view, remove unnecessary API calls<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9099 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
40 lines
2 KiB
Go HTML Template
40 lines
2 KiB
Go HTML Template
{{template "base/head" .}}
|
|
|
|
<div class="page-content repository">
|
|
{{template "repo/header" .}}
|
|
<div id="repo-action-view"
|
|
data-run-index="{{.RunIndex}}"
|
|
data-run-id="{{.RunID}}"
|
|
data-job-index="{{.JobIndex}}"
|
|
data-attempt-number="{{.AttemptNumber}}"
|
|
data-actions-url="{{.ActionsURL}}"
|
|
data-workflow-name="{{.WorkflowName}}"
|
|
data-workflow-url="{{.WorkflowURL}}"
|
|
data-initial-post-response="{{.InitialData}}"
|
|
data-initial-artifacts-response="{{.InitialArtifactsData}}"
|
|
data-locale-approve="{{ctx.Locale.Tr "repo.diff.review.approve"}}"
|
|
data-locale-cancel="{{ctx.Locale.Tr "cancel"}}"
|
|
data-locale-rerun="{{ctx.Locale.Tr "rerun"}}"
|
|
data-locale-rerun-all="{{ctx.Locale.Tr "rerun_all"}}"
|
|
data-locale-status-unknown="{{ctx.Locale.Tr "actions.status.unknown"}}"
|
|
data-locale-status-waiting="{{ctx.Locale.Tr "actions.status.waiting"}}"
|
|
data-locale-status-running="{{ctx.Locale.Tr "actions.status.running"}}"
|
|
data-locale-status-success="{{ctx.Locale.Tr "actions.status.success"}}"
|
|
data-locale-status-failure="{{ctx.Locale.Tr "actions.status.failure"}}"
|
|
data-locale-status-cancelled="{{ctx.Locale.Tr "actions.status.cancelled"}}"
|
|
data-locale-status-skipped="{{ctx.Locale.Tr "actions.status.skipped"}}"
|
|
data-locale-status-blocked="{{ctx.Locale.Tr "actions.status.blocked"}}"
|
|
data-locale-artifacts-title="{{ctx.Locale.Tr "artifacts"}}"
|
|
data-locale-confirm-delete-artifact="{{ctx.Locale.Tr "confirm_delete_artifact"}}"
|
|
data-locale-show-timestamps="{{ctx.Locale.Tr "show_timestamps"}}"
|
|
data-locale-show-log-seconds="{{ctx.Locale.Tr "show_log_seconds"}}"
|
|
data-locale-show-full-screen="{{ctx.Locale.Tr "show_full_screen"}}"
|
|
data-locale-download-logs="{{ctx.Locale.Tr "download_logs"}}"
|
|
data-locale-run-attempt-label="{{ctx.Locale.Tr "actions.runs.run_attempt_label"}}"
|
|
data-locale-viewing-out-of-date-run="{{ctx.Locale.Tr "actions.runs.viewing_out_of_date_run"}}"
|
|
data-locale-view-most-recent-run="{{ctx.Locale.Tr "actions.runs.view_most_recent_run"}}"
|
|
>
|
|
</div>
|
|
</div>
|
|
|
|
{{template "base/footer" .}}
|