mirror of
https://codeberg.org/forgejo/forgejo
synced 2025-09-17 03:02:55 +02:00
This patch is mainly intended to fix forgejo/forgejo#7721, and to fix forgejo/forgejo#9019. It also changes the evaluation of 0 limits to prevent all writes, instead of allowing one write and then failing on subsequent writes after the limit has been exceeded. This matches the expectation of the existing tests, and I believe it will better match the expectations of users. Tests have been updated accordingly where necessary, and some additional test coverage added. The fixes in this PR depend on each other in order for the quota system to function correctly, so I'm submitting them as a single PR instead of individually. ## Test Cases ### Quota subjects not covered by their parent subjects Before enabling quotas, create a test user and test repository for that user. Enable quotas, and set a default total to some large value. (Do not use unit suffixes forgejo/forgejo#8996) ```ini [quota] ENABLED = true [quota.default] TOTAL = 1073741824 ``` With the test user, navigate to "Storage overview" and verify that the quota group "Global quota" is the only group listed, containing the rule "Default", and displays the configured limit, and that the limit has not been exceeded (eg. `42 MiB / 1 GiB`). The default quota rule has the subject `size:all`, so any write action should be allowed. #### Attempt to create a new repository. Expected result: Repository is created. Actual result: Error 413, You have exhausted your quota. #### Attempt to create a new file in the existing repository. Expected result: File is created. Actual result: Error 413, You have exhausted your quota. #### Create an issue on the test repository, and attempt to upload an image to the issue. Expected result: Image is uploaded. Actual Result: Quota exceeded. Displays error message: `JavaScript promise rejection: can't access property "submitted", oi[ji.uuid] is undefined. Open browser console to see more details.` ### Unlimited quota rules incorrectly allow all writes With quotas enabled, [Use the API](https://forgejo.org/docs/latest/admin/advanced/quota/#advanced-usage-via-api) to create a quota group containing a single rule with a subject of `sizelfs`, and a limit of `-1` (Unlimited). Add the test user to this group. ```json { "name": "git-lfs-unlimited", "rules": [ { "name": "git-lfs-unlimited", "limit": -1, "subjects": ["size
lfs"] } ] } ``` With the test user, navigate to "Storage overview" and verify that the user has been added to this group, that it is the only group the user is assigned to, and that the rule limit displays as "Unlimited". The user should only have the ability to write to Git LFS storage, all other writes should be denied. #### Attempt to create a new repository. Expected result: Error 413, You have exhausted your quota. Actual result: Repository is created. #### Attempt to create a new file in the test repository. Expected result: Error 413, You have exhausted your quota. Actual result: File is created. #### Create an issue on the test repository, and attempt to upload an image to the issue. Expected Result: Quota exceeded. Actual result: Image is uploaded. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9033 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Brook Miles <brook@noreply.codeberg.org> Co-committed-by: Brook Miles <brook@noreply.codeberg.org>
134 lines
3.6 KiB
Go
134 lines
3.6 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
// This is primarily coped from /tests/integration/integration_test.go
|
|
// TODO: Move common functions to shared file
|
|
|
|
//nolint:forbidigo
|
|
package e2e
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/url"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"forgejo.org/models/unittest"
|
|
"forgejo.org/modules/graceful"
|
|
"forgejo.org/modules/log"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/test"
|
|
"forgejo.org/modules/testlogger"
|
|
"forgejo.org/modules/util"
|
|
"forgejo.org/modules/web"
|
|
"forgejo.org/routers"
|
|
"forgejo.org/tests"
|
|
)
|
|
|
|
var testE2eWebRoutes *web.Route
|
|
|
|
func TestMain(m *testing.M) {
|
|
defer log.GetManager().Close()
|
|
|
|
managerCtx, cancel := context.WithCancel(context.Background())
|
|
graceful.InitManager(managerCtx)
|
|
defer cancel()
|
|
|
|
tests.InitTest(true)
|
|
initChangedFiles()
|
|
testE2eWebRoutes = routers.NormalRoutes()
|
|
|
|
err := unittest.InitFixtures(
|
|
unittest.FixturesOptions{
|
|
Dir: filepath.Join(setting.AppWorkPath, "models/fixtures/"),
|
|
Base: setting.AppWorkPath,
|
|
Dirs: []string{"tests/e2e/fixtures/"},
|
|
},
|
|
)
|
|
if err != nil {
|
|
fmt.Printf("Error initializing test database: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
exitVal := m.Run()
|
|
|
|
if err := testlogger.WriterCloser.Reset(); err != nil {
|
|
fmt.Printf("testlogger.WriterCloser.Reset: error ignored: %v\n", err)
|
|
}
|
|
if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil {
|
|
fmt.Printf("util.RemoveAll: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
if err = util.RemoveAll(setting.Indexer.RepoPath); err != nil {
|
|
fmt.Printf("Unable to remove repo indexer: %v\n", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
os.Exit(exitVal)
|
|
}
|
|
|
|
// TestE2e should be the only test e2e necessary. It will collect all "*.test.e2e.js" files in this directory and build a test for each.
|
|
func TestE2e(t *testing.T) {
|
|
// Find the paths of all e2e test files in test directory.
|
|
searchGlob := filepath.Join(filepath.Dir(setting.AppPath), "tests", "e2e", "*.test.e2e.ts")
|
|
paths, err := filepath.Glob(searchGlob)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if len(paths) == 0 {
|
|
t.Fatal(fmt.Errorf("No e2e tests found in %s", searchGlob))
|
|
}
|
|
|
|
runArgs := []string{"npx", "playwright", "test"}
|
|
|
|
_, testVisual := os.LookupEnv("VISUAL_TEST")
|
|
// To update snapshot outputs
|
|
if _, set := os.LookupEnv("ACCEPT_VISUAL"); set {
|
|
runArgs = append(runArgs, "--update-snapshots")
|
|
}
|
|
if project := os.Getenv("PLAYWRIGHT_PROJECT"); project != "" {
|
|
runArgs = append(runArgs, "--project="+project)
|
|
}
|
|
|
|
// Create new test for each input file
|
|
for _, path := range paths {
|
|
_, filename := filepath.Split(path)
|
|
testname := filename[:len(filename)-len(filepath.Ext(path))]
|
|
|
|
if canSkipTest(path) {
|
|
fmt.Printf("No related changes for test, skipping: %s\n", filename)
|
|
continue
|
|
}
|
|
|
|
t.Run(testname, func(t *testing.T) {
|
|
if testname == "user-settings.test.e2e" {
|
|
defer test.MockVariableValue(&setting.Quota.Enabled, true)()
|
|
defer test.MockVariableValue(&testE2eWebRoutes, routers.NormalRoutes())()
|
|
}
|
|
|
|
// Default 2 minute timeout
|
|
onForgejoRun(t, func(*testing.T, *url.URL) {
|
|
defer DeclareGitRepos(t)()
|
|
thisTest := runArgs
|
|
// when all tests are run, use unique artifacts directories per test to preserve artifacts from other tests
|
|
if testVisual {
|
|
thisTest = append(thisTest, "--output=tests/e2e/test-artifacts/"+testname)
|
|
}
|
|
thisTest = append(thisTest, path)
|
|
cmd := exec.Command(runArgs[0], thisTest...)
|
|
cmd.Env = os.Environ()
|
|
cmd.Env = append(cmd.Env, fmt.Sprintf("GITEA_URL=%s", setting.AppURL))
|
|
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
|
|
err := cmd.Run()
|
|
if err != nil && !testVisual {
|
|
log.Fatal("Playwright Failed: %s", err)
|
|
}
|
|
})
|
|
})
|
|
}
|
|
}
|