No description
Find a file
forgejo-backport-action 714b88f8b2 [v13.0/forgejo] fix: db.Iterate can miss records, can return records twice (#9723)
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/9657

Fixes #9644.

Rewrites `db.Iterate` so that it performs DB queries in this format:
- First: `SELECT ...columns... FROM table ORDER BY id LIMIT ...buffer-size...`
- Subsequent buffer fills: adding a `WHERE id > ...last-id-from-previous...`

This approach:
- Prevents records from being missed or returned twice
- Returns records in a predictable order
- Should be faster, by virtue of using database indexes on the primary key to perform the query
- Doesn't rely on any unpredictable database behaviour when using `LIMIT` and `OFFSET` without an `ORDER BY`
- (Downside: does require reflection to read field values off Go structures for the primary key value)

Expands the automated tests to include the predicted failure case identified in #9644, which verified the previous broken behaviour, as well as verifying that the `cond` parameter is applied which was previously not covered by test automation.

Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9723
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
2025-10-17 06:45:24 +02:00
.devcontainer Update ghcr.io/devcontainers/features/git-lfs Docker tag to v1.2.5 (forgejo) (#8369) 2025-07-01 06:31:22 +02:00
.forgejo [v13.0/forgejo] chore(ci): limit LDAP service container memory usage to 500M (#9620) 2025-10-10 23:03:41 +02:00
assets [v13.0/forgejo] feat: strip EXIF information from uploaded avatars (#9689) 2025-10-15 08:53:51 +02:00
build chore(i18n): migrate migration descriptions to json (#9041) 2025-08-31 08:19:19 +02:00
cmd [v13.0/forgejo] feat: strip EXIF information from uploaded avatars (#9689) 2025-10-15 08:53:51 +02:00
contrib chore: collect coverage using GOCOVERDIR (#9004) 2025-08-26 10:10:46 +02:00
custom/conf docs: update example config docs for MAX_CREATION_LIMIT (#9376) 2025-09-21 09:09:40 +02:00
docker bugfix check for alternate ssh host certificate location (#34146) 2025-04-14 15:53:35 +02:00
models [v13.0/forgejo] fix: db.Iterate can miss records, can return records twice (#9723) 2025-10-17 06:45:24 +02:00
modules [v13.0/forgejo] fix: use scrollHeight for rendered iframe if offsetHeight is unavailable (#9713) 2025-10-16 16:53:54 +02:00
options [v13.0/forgejo] i18n: update of translations from Codeberg Translate 2025-10-09 23:46:41 +05:00
public Add support for migrating from Pagure (#8513) 2025-08-11 16:56:26 +02:00
release-notes [v13.0/forgejo] feat: strip EXIF information from uploaded avatars (#9689) 2025-10-15 08:53:51 +02:00
release-notes-published chore(release-notes): Forgejo v12.0.4 (#9368) 2025-09-20 08:51:49 +02:00
releases/images
routers display pre-execution errors in action view UI 2025-10-05 21:21:30 -06:00
services [v13.0/forgejo] fix: use scrollHeight for rendered iframe if offsetHeight is unavailable (#9713) 2025-10-16 16:53:54 +02:00
templates [v13.0/forgejo] fix: release email links (#9714) 2025-10-16 18:58:48 +02:00
tests [v13.0/forgejo] fix: use scrollHeight for rendered iframe if offsetHeight is unavailable (#9713) 2025-10-16 16:53:54 +02:00
tools chore: remove gopls in Makefile (#8205) 2025-06-17 08:28:26 +02:00
web_src [v13.0/forgejo] fix: avoid jumping to begin of page on edit comment action (#9645) (#9674) 2025-10-13 23:05:03 +02:00
.air.toml Reduce air verbosity (#31417) 2024-06-23 12:30:09 +02:00
.deadcode-out Sent user activities to distant federated server (#8792) 2025-08-06 16:16:13 +02:00
.dockerignore fix: Dockerfile should re-use bindata files when possible 2025-06-13 14:00:57 +02:00
.editorconfig Cover go.mod and go.sum in .editorconfig (#33960) 2025-04-01 02:28:02 +02:00
.envrc.example Make direnv optional to let developers use their own direnv configuration 2024-11-06 20:34:49 +01:00
.gitattributes
.gitignore feat(build): improve lint-locale-usage further (#8736) 2025-08-27 23:47:34 +02:00
.gitmodules
.gitpod.yml
.golangci.yml chore: depguard gopkg.in/yaml.v3 (#8980) 2025-08-21 14:17:43 +02:00
.ignore
.mailmap Add .mailmap with aliases for Unknwon (github.com/Unknwon) 2024-08-14 08:26:16 -04:00
.markdownlint.yaml
.npmrc
.release-notes-assistant.yaml chore(release-notes): no need to specify they are draft 2024-10-22 06:54:27 +02:00
.spectral.yaml
.yamllint.yaml
BSDmakefile feat: Makefile & BSDmakefile changes (#7455) 2025-04-27 10:04:32 +00:00
CODEOWNERS feat(build): improve lint-locale-usage further (#8736) 2025-08-27 23:47:34 +02:00
CONTRIBUTING.md docs: replace Developer Guide link with the new Contributor Guide one. 2024-08-26 13:22:39 +03:00
DCO
Dockerfile reverts "[v13.0/forgejo] fix: temporarily pin release builds to Go 1.24.7 (#9658)" (#9680) 2025-10-14 10:24:35 +02:00
Dockerfile.rootless reverts "[v13.0/forgejo] fix: temporarily pin release builds to Go 1.24.7 (#9658)" (#9680) 2025-10-14 10:24:35 +02:00
eslint.config.mjs Update dependency eslint-plugin-unicorn to v61 (forgejo) (#9198) 2025-09-07 14:55:32 +02:00
flake.lock chore: create shell.nix and update flake.* (#8129) 2025-06-10 14:31:59 +02:00
flake.nix chore: create shell.nix and update flake.* (#8129) 2025-06-10 14:31:59 +02:00
go.mod [v13.0/forgejo] feat: strip EXIF information from uploaded avatars (#9689) 2025-10-15 08:53:51 +02:00
go.sum [v13.0/forgejo] feat: strip EXIF information from uploaded avatars (#9689) 2025-10-15 08:53:51 +02:00
LICENSE Forgejo v9.0 is GPLv3+ 2024-08-22 09:09:29 +02:00
main.go fix: do not mix urfave v2 with urfave v3 (#8168) 2025-06-12 15:38:03 +02:00
Makefile [v13.0/forgejo] chore: TestParseGitURLs must use a valid IPv6 address (#9622) 2025-10-10 20:01:31 +02:00
manifest.scm Add a GNU Guix manifest (#8038) 2025-06-03 08:08:17 +02:00
package-lock.json Lock file maintenance (forgejo) (#9383) 2025-09-22 09:21:27 +02:00
package.json Update dependency mermaid to v11.12.0 (forgejo) (#9353) 2025-09-20 17:47:10 +02:00
playwright.config.ts tests(e2e): Prepare for visual regression testing 2024-12-10 18:12:36 +01:00
README.md chore: fix a few typos in the documentation (#9134) 2025-09-04 01:53:40 +02:00
release-notes-assistant.sh chore: improve the wording of the "not worth a release note" category (#8542) 2025-07-18 07:19:15 +02:00
RELEASE-NOTES.md RELEASE-NOTES.md to refer to the release notes directory on master [skip ci] (#8675) 2025-07-25 22:21:37 +02:00
renovate.json chore: fix renovate.json format error (#9148) 2025-09-03 21:42:56 +02:00
shell.nix chore: add missing gotestsum to nix dev shell (#9169) 2025-09-05 01:24:45 +02:00
stylelint.config.js
tailwind.config.js fix: Do not scan all Go files for tailwind classes 2024-08-24 15:45:50 +02:00
tsconfig.json Add typescript 2024-10-29 18:15:09 +01:00
vitest.config.ts Add typescript 2024-10-29 18:15:09 +01:00
webpack.config.js Update dependency htmx.org to v2 (forgejo) (#8342) 2025-06-29 13:52:24 +02:00

Welcome to Forgejo

Hi there! Tired of big platforms playing monopoly? Providing Git hosting for your project, friends, company or community? Forgejo (/for'd͡ʒe.jo/ inspired by forĝejo the Esperanto word for forge) has you covered with its intuitive interface, light and easy hosting and a lot of built-in functionality.

Forgejo was created in 2022 because we think that the project should be owned by an independent community. If you second that, then Forgejo is for you! Our promise: Independent Free/Libre Software forever!

What does Forgejo offer?

If you like any of the following, Forgejo is literally meant for you:

  • Lightweight: Forgejo can easily be hosted on nearly every machine. Running on a Raspberry? Small cloud instance? No problem!
  • Project management: Besides Git hosting, Forgejo offers issues, pull requests, wikis, kanban boards and much more to coordinate with your team.
  • Publishing: Have something to share? Use releases to host your software for download, or use the package registry to publish it for docker, npm and many other package managers.
  • Customizable: Want to change your look? Change some settings? There are many config switches to make Forgejo work exactly like you want.
  • Powerful: Organizations & team permissions, CI integration, Code Search, LDAP, OAuth and much more. If you have advanced needs, Forgejo has you covered.
  • Privacy: From update checker to default settings: Forgejo is built to be privacy first for you and your crew.
  • Federation: (WIP) We are actively working to connect software forges with each other through ActivityPub, and create a collaborative network of personal instances.

Learn more

Dive into the documentation, subscribe to releases and blog post on our website, find us on the Fediverse or hop into our Matrix room if you have any questions or want to get involved.

License

Forgejo is distributed under the terms of the GPL version 3.0 or any later version.

The agreement for this license was documented in June 2023 and implemented during the development of Forgejo v9.0. All Forgejo versions before v9.0 are distributed under the MIT license.

Get involved

If you are interested in making Forgejo better, either by reporting a bug or by changing the governance, please take a look at the contribution guide.