mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-08-23 16:11:12 +02:00
This PR do some loading speed optimization for feeds user interface pages. - Load action users batchly but not one by one. - Load action repositories batchly but not one by one. - Load action's Repo Owners batchly but not one by one. - Load action's possible issues batchly but not one by one. - Load action's possible comments batchly but not one by one. (cherry picked from commit aed3b53abdd02a3ffbf9e8eb90272ff567333073)
204 lines
4.8 KiB
Go
204 lines
4.8 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package activities
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/container"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
// ActionList defines a list of actions
|
|
type ActionList []*Action
|
|
|
|
func (actions ActionList) getUserIDs() []int64 {
|
|
userIDs := make(container.Set[int64], len(actions))
|
|
for _, action := range actions {
|
|
userIDs.Add(action.ActUserID)
|
|
}
|
|
return userIDs.Values()
|
|
}
|
|
|
|
func (actions ActionList) LoadActUsers(ctx context.Context) (map[int64]*user_model.User, error) {
|
|
if len(actions) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
userIDs := actions.getUserIDs()
|
|
userMaps := make(map[int64]*user_model.User, len(userIDs))
|
|
err := db.GetEngine(ctx).
|
|
In("id", userIDs).
|
|
Find(&userMaps)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("find user: %w", err)
|
|
}
|
|
|
|
for _, action := range actions {
|
|
action.ActUser = userMaps[action.ActUserID]
|
|
}
|
|
return userMaps, nil
|
|
}
|
|
|
|
func (actions ActionList) getRepoIDs() []int64 {
|
|
repoIDs := make(container.Set[int64], len(actions))
|
|
for _, action := range actions {
|
|
repoIDs.Add(action.RepoID)
|
|
}
|
|
return repoIDs.Values()
|
|
}
|
|
|
|
func (actions ActionList) LoadRepositories(ctx context.Context) error {
|
|
if len(actions) == 0 {
|
|
return nil
|
|
}
|
|
|
|
repoIDs := actions.getRepoIDs()
|
|
repoMaps := make(map[int64]*repo_model.Repository, len(repoIDs))
|
|
err := db.GetEngine(ctx).In("id", repoIDs).Find(&repoMaps)
|
|
if err != nil {
|
|
return fmt.Errorf("find repository: %w", err)
|
|
}
|
|
for _, action := range actions {
|
|
action.Repo = repoMaps[action.RepoID]
|
|
}
|
|
repos := repo_model.RepositoryList(util.ValuesOfMap(repoMaps))
|
|
return repos.LoadUnits(ctx)
|
|
}
|
|
|
|
func (actions ActionList) loadRepoOwner(ctx context.Context, userMap map[int64]*user_model.User) (err error) {
|
|
if userMap == nil {
|
|
userMap = make(map[int64]*user_model.User)
|
|
}
|
|
|
|
userSet := make(container.Set[int64], len(actions))
|
|
for _, action := range actions {
|
|
if action.Repo == nil {
|
|
continue
|
|
}
|
|
if _, ok := userMap[action.Repo.OwnerID]; !ok {
|
|
userSet.Add(action.Repo.OwnerID)
|
|
}
|
|
}
|
|
|
|
if err := db.GetEngine(ctx).
|
|
In("id", userSet.Values()).
|
|
Find(&userMap); err != nil {
|
|
return fmt.Errorf("find user: %w", err)
|
|
}
|
|
|
|
for _, action := range actions {
|
|
if action.Repo != nil {
|
|
action.Repo.Owner = userMap[action.Repo.OwnerID]
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// LoadAttributes loads all attributes
|
|
func (actions ActionList) LoadAttributes(ctx context.Context) error {
|
|
// the load sequence cannot be changed because of the dependencies
|
|
userMap, err := actions.LoadActUsers(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := actions.LoadRepositories(ctx); err != nil {
|
|
return err
|
|
}
|
|
if err := actions.loadRepoOwner(ctx, userMap); err != nil {
|
|
return err
|
|
}
|
|
if err := actions.LoadIssues(ctx); err != nil {
|
|
return err
|
|
}
|
|
return actions.LoadComments(ctx)
|
|
}
|
|
|
|
func (actions ActionList) LoadComments(ctx context.Context) error {
|
|
if len(actions) == 0 {
|
|
return nil
|
|
}
|
|
|
|
commentIDs := make([]int64, 0, len(actions))
|
|
for _, action := range actions {
|
|
if action.CommentID > 0 {
|
|
commentIDs = append(commentIDs, action.CommentID)
|
|
}
|
|
}
|
|
|
|
commentsMap := make(map[int64]*issues_model.Comment, len(commentIDs))
|
|
if err := db.GetEngine(ctx).In("id", commentIDs).Find(&commentsMap); err != nil {
|
|
return fmt.Errorf("find comment: %w", err)
|
|
}
|
|
|
|
for _, action := range actions {
|
|
if action.CommentID > 0 {
|
|
action.Comment = commentsMap[action.CommentID]
|
|
if action.Comment != nil {
|
|
action.Comment.Issue = action.Issue
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (actions ActionList) LoadIssues(ctx context.Context) error {
|
|
if len(actions) == 0 {
|
|
return nil
|
|
}
|
|
|
|
conditions := builder.NewCond()
|
|
issueNum := 0
|
|
for _, action := range actions {
|
|
if action.IsIssueEvent() {
|
|
infos := action.GetIssueInfos()
|
|
if len(infos) == 0 {
|
|
continue
|
|
}
|
|
index, _ := strconv.ParseInt(infos[0], 10, 64)
|
|
if index > 0 {
|
|
conditions = conditions.Or(builder.Eq{
|
|
"repo_id": action.RepoID,
|
|
"`index`": index,
|
|
})
|
|
issueNum++
|
|
}
|
|
}
|
|
}
|
|
if !conditions.IsValid() {
|
|
return nil
|
|
}
|
|
|
|
issuesMap := make(map[string]*issues_model.Issue, issueNum)
|
|
issues := make([]*issues_model.Issue, 0, issueNum)
|
|
if err := db.GetEngine(ctx).Where(conditions).Find(&issues); err != nil {
|
|
return fmt.Errorf("find issue: %w", err)
|
|
}
|
|
for _, issue := range issues {
|
|
issuesMap[fmt.Sprintf("%d-%d", issue.RepoID, issue.Index)] = issue
|
|
}
|
|
|
|
for _, action := range actions {
|
|
if !action.IsIssueEvent() {
|
|
continue
|
|
}
|
|
if index := action.getIssueIndex(); index > 0 {
|
|
if issue, ok := issuesMap[fmt.Sprintf("%d-%d", action.RepoID, index)]; ok {
|
|
action.Issue = issue
|
|
action.Issue.Repo = action.Repo
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|