forgejo/models
Gusted 8fb027fea5
[BUG] Ensure HasIssueContentHistory takes into account comment_id
- Backport of #2518
- The content history table contains the content history of issues and
comments. For issues they are saved with an comment id of zero.
- If you want to check if the issue has an content history, it should
take into account that SQL has `comment_id = 0`, as it otherwise could
return incorrect results when for example the issue already has an
comment that has an content history.
- Fix the code of `HasIssueContentHistory` to take this into account, it
relied on XORM to generate the SQL from the non-default values of the
struct, this wouldn't generate the `comment_id = 0` SQL as `0` is the
default value of an integer.
- Remove an unncessary log (it's not the responsibility of `models`
code to do logging).
- Adds unit test.
- Resolves #2513

(cherry picked from commit 331fa44956)
2024-03-01 15:48:42 +01:00
..
actions Only check online runner when detecting matching runners in workflows (#28286) (#28512) 2023-12-22 12:10:03 +01:00
activities Revert "Speed up loading the dashboard on mysql/mariadb (#28546)" (#29006) (#29007) 2024-02-01 20:56:23 +01:00
admin
asymkey Retry SSH key verification with additional CRLF if it failed (#28392) (#28464) 2023-12-22 12:05:11 +01:00
auth [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
avatars
db Avoid cycle-redirecting user/login page (#28636) (#28658) 2024-01-16 14:11:44 +00:00
dbfs
fixtures Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
forgejo/semver
forgejo_migrations [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
git Fix GetCommitStatuses (#28787) (#28804) 2024-01-16 14:40:56 +00:00
issues [BUG] Ensure HasIssueContentHistory takes into account comment_id 2024-03-01 15:48:42 +01:00
migrations handle repository.size column being NULL in migration v263 (#28336) (#28363) 2023-12-08 13:41:16 +01:00
organization
packages
perm
project Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
pull [GITEA] GetScheduledMergeByPullID may involve a system user 2023-12-11 18:43:03 +01:00
repo Don't remove all mirror repository's releases when mirroring (#28817) (#28939) 2024-01-31 14:18:26 +01:00
secret
shared/types
system Increase "version" when update the setting value to a same value as before (#28243) (#28244) 2023-12-08 13:40:59 +01:00
unit
unittest Workaround to clean up old reviews on creating a new one (#28554) (#29264) 2024-02-20 09:39:02 +01:00
user Forbid removing the last admin user (#28337) (#28793) 2024-01-16 14:41:11 +00:00
webhook Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
error.go Forbid removing the last admin user (#28337) (#28793) 2024-01-16 14:41:11 +00:00
fixture_generation.go
fixture_test.go
main_test.go
org.go
org_team.go
org_team_test.go
org_test.go
repo.go
repo_test.go
repo_transfer.go
repo_transfer_test.go