mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-05-19 18:50:36 +02:00
61b89747ed
This PR refactors and improves the password hashing code within gitea and makes it possible for server administrators to set the password hashing parameters In addition it takes the opportunity to adjust the settings for `pbkdf2` in order to make the hashing a little stronger. The majority of this work was inspired by PR #14751 and I would like to thank @boppy for their work on this. Thanks to @gusted for the suggestion to adjust the `pbkdf2` hashing parameters. Close #14751 --------- Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
39 lines
1.2 KiB
Go
39 lines
1.2 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package hash
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCheckSettingPasswordHashAlgorithm(t *testing.T) {
|
|
t.Run("pbkdf2 is pbkdf2_v2", func(t *testing.T) {
|
|
pbkdf2v2Config, pbkdf2v2Algo := SetDefaultPasswordHashAlgorithm("pbkdf2_v2")
|
|
pbkdf2Config, pbkdf2Algo := SetDefaultPasswordHashAlgorithm("pbkdf2")
|
|
|
|
assert.Equal(t, pbkdf2v2Config, pbkdf2Config)
|
|
assert.Equal(t, pbkdf2v2Algo.Specification, pbkdf2Algo.Specification)
|
|
})
|
|
|
|
for a, b := range aliasAlgorithmNames {
|
|
t.Run(a+"="+b, func(t *testing.T) {
|
|
aConfig, aAlgo := SetDefaultPasswordHashAlgorithm(a)
|
|
bConfig, bAlgo := SetDefaultPasswordHashAlgorithm(b)
|
|
|
|
assert.Equal(t, bConfig, aConfig)
|
|
assert.Equal(t, aAlgo.Specification, bAlgo.Specification)
|
|
})
|
|
}
|
|
|
|
t.Run("pbkdf2_v2 is the default when default password hash algorithm is empty", func(t *testing.T) {
|
|
emptyConfig, emptyAlgo := SetDefaultPasswordHashAlgorithm("")
|
|
pbkdf2v2Config, pbkdf2v2Algo := SetDefaultPasswordHashAlgorithm("pbkdf2_v2")
|
|
|
|
assert.Equal(t, pbkdf2v2Config, emptyConfig)
|
|
assert.Equal(t, pbkdf2v2Algo.Specification, emptyAlgo.Specification)
|
|
})
|
|
}
|