forgejo/services/repository
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
archiver fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2022-08-29 11:45:20 +02:00
files Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
adopt.go Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
adopt_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
avatar.go Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
avatar_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
branch.go Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
cache.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
check.go Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
fork.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
fork_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
hooks.go Move some repository related code into sub package (#19711) 2022-06-06 16:01:49 +08:00
main_test.go Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
push.go Fix incorrect notification commit url (#21479) 2022-10-17 12:58:20 +08:00
repository.go Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
repository_test.go Move some repository related code into sub package (#19711) 2022-06-06 16:01:49 +08:00
review.go Move some repository related code into sub package (#19711) 2022-06-06 16:01:49 +08:00
review_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
template.go Remove manual rollback for failed generated repositories (#20639) 2022-08-09 17:41:52 +08:00
transfer.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
transfer_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00