forgejo/modules/util
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
filebuffer Fix package upload for files >32mb (#20622) 2022-08-02 21:35:48 +08:00
compare.go
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
file_unix.go Save files in local storage as umask (#21198) 2022-09-24 21:04:14 +08:00
file_unix_test.go Save files in local storage as umask (#21198) 2022-09-24 21:04:14 +08:00
file_windows.go Save files in local storage as umask (#21198) 2022-09-24 21:04:14 +08:00
io.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
legacy.go Remove legacy unknwon/com package (#19298) 2022-04-02 00:34:57 +08:00
legacy_test.go Remove legacy unknwon/com package (#19298) 2022-04-02 00:34:57 +08:00
paginate.go
paginate_test.go
path.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
path_test.go
remove.go
sanitize.go
sanitize_test.go
sec_to_time.go Fix SecToTime edge-cases (#20610) 2022-08-08 13:07:42 +08:00
sec_to_time_test.go Fix SecToTime edge-cases (#20610) 2022-08-08 13:07:42 +08:00
shellquote.go
shellquote_test.go
slice.go
string.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
string_test.go Remove legacy unknwon/com package (#19298) 2022-04-02 00:34:57 +08:00
timer.go
truncate.go
truncate_test.go
url.go
util.go Prettify number of issues (#17760) 2022-06-12 20:08:23 +08:00
util_test.go Fix copy/paste of empty lines (#19798) 2022-06-10 21:45:28 +08:00