forgejo/services
Giteabot 693c2b4f15
Fix migration panic due to an empty review comment diff (#28334) (#28362)
Backport #28334 by @lng2020

Fix #28328
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
(cherry picked from commit 8b590de186)
2023-12-08 13:41:16 +01:00
..
actions
agit
asymkey
attachment
auth
automerge
context
convert
cron
externalaccount
feed
forgejo
forms
gitdiff
indexer Fix missing issue search index update when changing status (#28325) (#28330) 2023-12-08 13:41:16 +01:00
issue
lfs
mailer [GITEA] notifies admins on new user registration (squash) fix locale 2023-12-06 18:36:17 +01:00
markup
migrations Fix migration panic due to an empty review comment diff (#28334) (#28362) 2023-12-08 13:41:16 +01:00
mirror
notify
org
packages Fix RPM/Debian signature key creation (#28352) (#28353) 2023-12-08 13:41:16 +01:00
pull
release
repository [GITEA] Add download URL for executable files 2023-12-04 17:19:13 +00:00
secrets
task
uinotification
user
webhook
wiki