mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-05-23 13:01:21 +02:00
4938945668
Currently gitea shows no commit information for files starting with a colon. [I set up a minimal repro repository that reproduces this error once it's migrated on gitea](https://github.com/kbolashev/colon-test) <img width="1209" alt="image" src="https://user-images.githubusercontent.com/111061261/219326625-0e6d3a86-8b58-4d67-bc24-8a78963f36b9.png"> This is happening because the filenames piped to the `git log` command are written as is, and it doesn't work when you have a colon at the start of the filename, and you need to escape it. You can test it locally, if you do ``` mkdir repo git init touch :file git add . && git commit -m "Add file with colon" git log -- :file ``` git log returns nothing. However, if you do `git log -- "\:file"`, it will show the commit with the file change. This PR escapes the starting colons in paths in the `LogNameStatusRepo` function, making gitea return commit info about the file with the bad filename. <img width="1209" alt="image" src="https://user-images.githubusercontent.com/111061261/219328299-46451246-4006-45e3-89b1-c244635ded23.png"> This error shows up only with files starting with colon, anywhere else in filename is ok. Dashes at the beginning also seem to be working. I don't know gitea internals well enough to know where else this error can pop up, so I'm keeping this PR small as suggested by your contributor guide |
||
---|---|---|
.. | ||
foreachref | ||
internal | ||
pipeline | ||
tests/repos | ||
url | ||
batch_reader.go | ||
blame.go | ||
blame_test.go | ||
blob.go | ||
blob_gogit.go | ||
blob_nogogit.go | ||
blob_test.go | ||
command.go | ||
command_race_test.go | ||
command_test.go | ||
commit.go | ||
commit_convert_gogit.go | ||
commit_info.go | ||
commit_info_gogit.go | ||
commit_info_nogogit.go | ||
commit_info_test.go | ||
commit_reader.go | ||
commit_test.go | ||
diff.go | ||
diff_test.go | ||
error.go | ||
git.go | ||
git_test.go | ||
hook.go | ||
last_commit_cache.go | ||
last_commit_cache_gogit.go | ||
last_commit_cache_nogogit.go | ||
log_name_status.go | ||
notes.go | ||
notes_gogit.go | ||
notes_nogogit.go | ||
notes_test.go | ||
parse_gogit.go | ||
parse_gogit_test.go | ||
parse_nogogit.go | ||
parse_nogogit_test.go | ||
README.md | ||
ref.go | ||
remote.go | ||
repo.go | ||
repo_archive.go | ||
repo_attribute.go | ||
repo_attribute_test.go | ||
repo_base.go | ||
repo_base_gogit.go | ||
repo_base_nogogit.go | ||
repo_blame.go | ||
repo_blob.go | ||
repo_blob_gogit.go | ||
repo_blob_nogogit.go | ||
repo_blob_test.go | ||
repo_branch.go | ||
repo_branch_gogit.go | ||
repo_branch_nogogit.go | ||
repo_branch_test.go | ||
repo_commit.go | ||
repo_commit_gogit.go | ||
repo_commit_nogogit.go | ||
repo_commit_test.go | ||
repo_commitgraph.go | ||
repo_commitgraph_gogit.go | ||
repo_compare.go | ||
repo_compare_test.go | ||
repo_gpg.go | ||
repo_hook.go | ||
repo_index.go | ||
repo_language_stats.go | ||
repo_language_stats_gogit.go | ||
repo_language_stats_nogogit.go | ||
repo_language_stats_test.go | ||
repo_object.go | ||
repo_ref.go | ||
repo_ref_gogit.go | ||
repo_ref_nogogit.go | ||
repo_ref_test.go | ||
repo_stats.go | ||
repo_stats_test.go | ||
repo_tag.go | ||
repo_tag_gogit.go | ||
repo_tag_nogogit.go | ||
repo_tag_test.go | ||
repo_test.go | ||
repo_tree.go | ||
repo_tree_gogit.go | ||
repo_tree_nogogit.go | ||
sha1.go | ||
sha1_gogit.go | ||
sha1_nogogit.go | ||
sha1_test.go | ||
signature.go | ||
signature_gogit.go | ||
signature_nogogit.go | ||
submodule.go | ||
submodule_test.go | ||
tag.go | ||
tag_test.go | ||
tree.go | ||
tree_blob.go | ||
tree_blob_gogit.go | ||
tree_blob_nogogit.go | ||
tree_entry.go | ||
tree_entry_gogit.go | ||
tree_entry_mode.go | ||
tree_entry_nogogit.go | ||
tree_entry_test.go | ||
tree_gogit.go | ||
tree_nogogit.go | ||
utils.go | ||
utils_test.go |
Git Module
This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.