forgejo/services
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
actions Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00
agit
asymkey Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
attachment
auth Refactor timeutil package (#28623) 2023-12-28 10:09:57 +00:00
automerge
context
convert Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
cron
externalaccount
feed
forms Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
gitdiff
indexer
issue
lfs
mailer Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
markup
migrations Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
mirror Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
notify
org
packages Support for grouping RPMs using paths (#26984) 2024-01-12 03:16:05 +00:00
pull Concatenate error in checkIfPRContentChanged (#28731) 2024-01-09 10:32:14 +08:00
release Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repository Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task
uinotification
user Forbid removing the last admin user (#28337) 2024-01-15 06:51:43 +00:00
webhook
wiki Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00