forgejo/modules/indexer/code
silverwind 60e4a98ab0
Preserve BOM in web editor (#28935)
The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.
2024-01-27 18:02:51 +00:00
..
bleve Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
elasticsearch Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
internal Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
git.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
indexer.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
indexer_test.go Replace assert.Fail with assert.FailNow (#27578) 2023-10-11 11:02:24 +00:00
search.go Add option to disable ambiguous unicode characters detection (#28454) 2023-12-17 14:38:54 +00:00