forgejo/modules
Lunny Xiao ca67c5a8a7
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 13:53:28 +08:00
..
activitypub
analyze
auth
avatar
base
cache
charset
container
context refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
convert
csv
doctor
emoji
eventsource
generate
git Use complete SHA to create and query commit status (#22244) 2022-12-27 21:12:49 +08:00
gitgraph
graceful
hcaptcha
highlight
hostmatcher
html
httpcache
httplib
indexer
issue/template
json
lfs
log
markup Remove deadcode (#22245) 2022-12-27 09:15:35 +08:00
mcaptcha
metrics
migration
mirror
nosql
notification
options
packages Normalize NuGet package version on upload (#22186) 2022-12-20 22:20:23 -05:00
paginator
password
pprof
private
process
proxy
proxyprotocol
public
queue
recaptcha
references
regexplru
repository
secret
session
setting Add option to prohibit fork if user reached maximum limit of repositories (#21848) 2022-12-27 15:21:14 -06:00
sitemap
ssh
storage
structs
svg
sync
system
templates
test
timeutil Check for zero time instant in TimeStamp.IsZero() (#22171) 2022-12-20 10:04:55 +08:00
translation
typesniffer
updatechecker
upload
uri
user
util
validation
watcher
web