forgejo/modules
Kyle Evans 38cd9ba47b
Allow unauthenticated users to compare (#11240)
* routers: make /compare route available to unauthenticated users

Remove some bits of the compare interface if the user isn't signed in.
Notably, they don't need to see the "New Pull Request" button box nor the
hidden form that would fail to submit due to the POST request continuing to
require proper privileges.

Follow-up commits will improve the UI a bit around this, removing some
"Pull Request" verbiage in favor of "Compare."

* ui: home: show "compare" button for unauthenticated users

This change requires pulling in the BaseRepo unconditionally and
recording if the pull request is in-fact not allowed
(.PullRequestCtx.Allowed). If the user isn't allowed to create a pull
request, either because this isn't a fork or same-fork branch PRs aren't
allowed, then we'll name the button "Compare" instead of "Pull Request."

* ui: branch list: use the new Compare language when available

When viewing the branch listing as an unauthenticated user, you'll get
"Pull Request" buttons. use the new "Compare" verbiage instead, which
matches GitHub behavior when you can't issue a pull request from the
branches.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
2020-05-04 19:44:30 -03:00
..
analyze
auth Add option to increase provided OAuth2 token maximum size (#11180) 2020-04-23 00:47:23 +02:00
avatar
base
cache
charset
context Allow unauthenticated users to compare (#11240) 2020-05-04 19:44:30 -03:00
convert API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
cron
emoji Support unicode emojis and remove emojify.js (#11032) 2020-04-28 15:05:39 -03:00
generate
git Support unicode emojis and remove emojify.js (#11032) 2020-04-28 15:05:39 -03:00
gitgraph
graceful Prevent panic during wrappedConn close at hammertime (#11219) 2020-04-26 21:01:06 -03:00
highlight
httplib
indexer
lfs
log
markup Restore checkbox rendering and prevent poor sanitization of spans (#11277) 2020-05-03 17:17:24 -03:00
metrics
migrations
notification Fix spelling mistake with Rewiew (#11262) 2020-04-30 21:24:08 +01:00
options
password
pprof
private
process
public
queue
recaptcha
references
repofiles Fix GetContents(): Dont't ignore Executables (#11192) 2020-04-24 19:20:22 +03:00
repository
secret
session
setting Sendmail should create a process on the gitea system and have a default timeout (#11256) 2020-05-03 00:04:31 +01:00
ssh
structs API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
sync
task
templates Support unicode emojis and remove emojify.js (#11032) 2020-04-28 15:05:39 -03:00
test
timeutil
upload
user
util
validation
webhook