From 2a5629dd28410658129513dbb08048e06761e502 Mon Sep 17 00:00:00 2001 From: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.com> Date: Tue, 2 Aug 2022 01:29:44 +0500 Subject: [PATCH] align --- weed/stats/metrics_names.go | 3 ++- weed/topology/store_replicate.go | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/weed/stats/metrics_names.go b/weed/stats/metrics_names.go index d4f9c23c9..722f4ad94 100644 --- a/weed/stats/metrics_names.go +++ b/weed/stats/metrics_names.go @@ -4,7 +4,8 @@ package stats // The naming convention is ErrorSomeThing = "error.some.thing" const ( // volume server - LocalWrite = "localWrite" + WriteToLocalDisk = "writeToLocalDisk" + WriteToReplicas = "writeToReplicas" ReplicatedWrite = "replicatedWrite" ErrorSizeMismatchOffsetSize = "errorSizeMismatchOffsetSize" ErrorSizeMismatch = "errorSizeMismatch" diff --git a/weed/topology/store_replicate.go b/weed/topology/store_replicate.go index 0fff29ba6..816f1fbe4 100644 --- a/weed/topology/store_replicate.go +++ b/weed/topology/store_replicate.go @@ -46,7 +46,7 @@ func ReplicatedWrite(masterFn operation.GetMasterFn, grpcDialOption grpc.DialOpt if s.GetVolume(volumeId) != nil { start := time.Now() isUnchanged, err = s.WriteVolumeNeedle(volumeId, n, true, fsync) - stats.VolumeServerRequestHistogram.WithLabelValues(stats.LocalWrite).Observe(time.Since(start).Seconds()) + stats.VolumeServerRequestHistogram.WithLabelValues(stats.WriteToLocalDisk).Observe(time.Since(start).Seconds()) if err != nil { stats.VolumeServerRequestCounter.WithLabelValues(stats.ErrorWriteToLocalDisk).Inc() err = fmt.Errorf("failed to write to local disk: %v", err) @@ -102,7 +102,7 @@ func ReplicatedWrite(masterFn operation.GetMasterFn, grpcDialOption grpc.DialOpt _, err := operation.UploadData(n.Data, uploadOption) return err }) - stats.VolumeServerRequestHistogram.WithLabelValues(stats.ReplicatedWrite).Observe(time.Since(start).Seconds()) + stats.VolumeServerRequestHistogram.WithLabelValues(stats.WriteToReplicas).Observe(time.Since(start).Seconds()) if err != nil { stats.VolumeServerRequestCounter.WithLabelValues(stats.ErrorWriteToReplicas).Inc() err = fmt.Errorf("failed to write to replicas for volume %d: %v", volumeId, err)