From 410b818aa7d99bcc830d0dbafac9c7298a2afceb Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Mon, 19 Oct 2020 14:24:57 -0700 Subject: [PATCH] master: avoid timer leakage --- weed/topology/topology_vacuum.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/weed/topology/topology_vacuum.go b/weed/topology/topology_vacuum.go index 4f3d69627..7bf55d131 100644 --- a/weed/topology/topology_vacuum.go +++ b/weed/topology/topology_vacuum.go @@ -42,13 +42,17 @@ func batchVacuumVolumeCheck(grpcDialOption grpc.DialOption, vl *VolumeLayout, vi }(index, dn.Url(), vid) } vacuumLocationList := NewVolumeLocationList() + + waitTimeout := time.NewTimer(30 * time.Minute) + defer waitTimeout.Stop() + for range locationlist.list { select { case index := <-ch: if index != -1 { vacuumLocationList.list = append(vacuumLocationList.list, locationlist.list[index]) } - case <-time.After(30 * time.Minute): + case <-waitTimeout.C: return vacuumLocationList, false } } @@ -81,11 +85,15 @@ func batchVacuumVolumeCompact(grpcDialOption grpc.DialOption, vl *VolumeLayout, }(index, dn.Url(), vid) } isVacuumSuccess := true + + waitTimeout := time.NewTimer(30 * time.Minute) + defer waitTimeout.Stop() + for range locationlist.list { select { case canCommit := <-ch: isVacuumSuccess = isVacuumSuccess && canCommit - case <-time.After(30 * time.Minute): + case <-waitTimeout.C: return false } }