From 93d0ad09affdf1b5e916574cf76a1eeb2b5838c6 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 16 Dec 2018 17:37:10 -0800 Subject: [PATCH] error log format --- weed/command/filer.go | 2 +- weed/command/server.go | 2 +- weed/command/volume.go | 2 +- weed/server/common.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/weed/command/filer.go b/weed/command/filer.go index f4d6f55a8..0c1950f96 100644 --- a/weed/command/filer.go +++ b/weed/command/filer.go @@ -126,7 +126,7 @@ func (fo *FilerOptions) startFiler() { }() } - glog.V(0).Infoln("Start Seaweed Filer", util.VERSION, "at port", strconv.Itoa(*fo.port)) + glog.V(0).Infof("Start Seaweed Filer %s at %s:%d", util.VERSION, *fo.ip, *fo.port) filerListener, e := util.NewListener( ":"+strconv.Itoa(*fo.port), time.Duration(10)*time.Second, diff --git a/weed/command/server.go b/weed/command/server.go index aaca5c724..8f760942c 100644 --- a/weed/command/server.go +++ b/weed/command/server.go @@ -173,7 +173,7 @@ func runServer(cmd *Command, args []string) bool { serverWhiteList, *serverSecureKey, ) - glog.V(0).Infoln("Start Seaweed Master", util.VERSION, "at", *serverIp+":"+strconv.Itoa(*masterPort)) + glog.V(0).Infof("Start Seaweed Master %s at %s:%d", util.VERSION, *serverIp, *masterPort) masterListener, e := util.NewListener(*serverBindIp+":"+strconv.Itoa(*masterPort), 0) if e != nil { glog.Fatalf("Master startup error: %v", e) diff --git a/weed/command/volume.go b/weed/command/volume.go index f283ef113..27a075b5b 100644 --- a/weed/command/volume.go +++ b/weed/command/volume.go @@ -155,7 +155,7 @@ func (v VolumeServerOptions) startVolumeServer(volumeFolders, maxVolumeCounts, v ) listeningAddress := *v.bindIp + ":" + strconv.Itoa(*v.port) - glog.V(0).Infoln("Start Seaweed volume server", util.VERSION, "at", listeningAddress) + glog.V(0).Infof("Start Seaweed volume server %s at %s", util.VERSION, listeningAddress) listener, e := util.NewListener(listeningAddress, time.Duration(*v.idleConnectionTimeout)*time.Second) if e != nil { glog.Fatalf("Volume server listener error:%v", e) diff --git a/weed/server/common.go b/weed/server/common.go index 005424f6d..7dfe9981c 100644 --- a/weed/server/common.go +++ b/weed/server/common.go @@ -69,7 +69,7 @@ func writeJson(w http.ResponseWriter, r *http.Request, httpStatus int, obj inter // wrapper for writeJson - just logs errors func writeJsonQuiet(w http.ResponseWriter, r *http.Request, httpStatus int, obj interface{}) { if err := writeJson(w, r, httpStatus, obj); err != nil { - glog.V(0).Infof("error writing JSON %s: %v", obj, err) + glog.V(0).Infof("error writing JSON %s status %d: %v", obj, httpStatus, err) } } func writeJsonError(w http.ResponseWriter, r *http.Request, httpStatus int, err error) {