1
0
Fork 0
mirror of https://github.com/chrislusf/seaweedfs synced 2025-09-18 01:02:46 +02:00
seaweedfs/weed
Warren Hodgkinson a1a76ccb8c
Fix for DeleteMultipleObjectsHandler wrongly deleting parent folders (#6380)
What problem are we solving?
Fix: #6379

How are we solving the problem?
We check for the AllowEmptyFolders option prior to cascade
deleting parent folders in S3 DeleteMultipleObjectsHandler.

How is the PR tested?
We ran SeaweedFS in a Kubernetes Cluster with a joint Filer
and S3 server in one container, with leveldb2 as the filer storage,
and AllowEmptyFolders set to true.

When using the Distribution Registry as the S3 client, it calls the
DeleteMultipleObjectsHandler as part of the artifact upload process
(uploads to a temp location, then performs a copy and delete).
Without this fix, the deletion cascade deleted parent folder until
the entire contents of the bucket were gone.

With this fix, the existing content of the bucket remained, and the
newly uploaded content was added.

Checks
[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
2024-12-19 18:00:08 -08:00
..
cluster init candidate servers when setting a starting snapshot 2024-05-05 14:16:26 -07:00
command mount metacache add ttl (#6360) 2024-12-16 20:19:32 -08:00
filer format error 2024-11-21 08:52:39 -08:00
filer_client merge current message queue code changes (#6201) 2024-11-04 12:08:25 -08:00
ftpd chore: fix function names in comment (#5478) 2024-04-08 07:19:02 -07:00
glog rotate log files 2022-12-11 21:05:58 -08:00
iamapi refactor all methods strings to const (#5726) 2024-07-01 01:00:39 -07:00
images Migrates from disintegration/imaging c2019 to cognusion/imaging c2024. (#5533) 2024-04-24 23:16:04 -07:00
mount mount metacache add ttl (#6360) 2024-12-16 20:19:32 -08:00
mq merge current message queue code changes (#6201) 2024-11-04 12:08:25 -08:00
notification go fmt 2022-09-14 23:06:44 -07:00
operation Fix/parse upload filename (#6241) 2024-11-15 11:25:18 -08:00
pb backward compatible vif loading 2024-10-28 19:44:30 -07:00
query move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
remote_storage remove unused 2024-06-28 14:54:39 -07:00
replication Azure sink: avoid overwriting existing files 2024-07-17 23:14:36 -07:00
s3api Fix for DeleteMultipleObjectsHandler wrongly deleting parent folders (#6380) 2024-12-19 18:00:08 -08:00
security [security] reload whiteList on http seerver (#6302) 2024-12-02 10:38:10 -08:00
sequence remove unused function 2024-06-25 09:18:11 -07:00
server [shell] feat:stop vacuum immediately once volume.vacuum.disable was executed (#6375) 2024-12-18 11:56:40 -08:00
shell Fix volume replica parallelization within ec.encode. (#6377) 2024-12-19 17:46:11 -08:00
static Fix Broken Links (#5287) 2024-02-14 08:26:38 -08:00
stats fix: filer may crash by bucketLastActiveTsNs concurrency access. (#6350) 2024-12-13 05:30:21 -08:00
storage Update disk_location_ec.go (#6359) 2024-12-15 22:05:47 -08:00
topology [shell] feat:stop vacuum immediately once volume.vacuum.disable was executed (#6375) 2024-12-18 11:56:40 -08:00
util ReadAt may return io.EOF t end of file 2024-11-21 00:37:38 -08:00
wdclient ExclusiveLocker only create one renew goroutine (#6269) 2024-11-21 08:27:12 -08:00
Makefile fix EC reading on nLargeBlockRows 2024-08-13 12:01:46 -07:00
weed.go Added tls for http clients (#5766) 2024-07-16 23:14:09 -07:00