PeterCxy/OpenEUICC
16
24
Fork 20
Code Issues 7 Pull requests Projects Releases 8 Wiki Activity Actions

refactor: certificate issuer detecting #102

Closed
septs wants to merge 11 commits from septs:ci-detect into master
pull from: septs:ci-detect
merge into: PeterCxy:master
Conversation 0 Commits 11 Files changed 3 +43 -25
septs commented 2024-12-10 12:11:16 +01:00
Contributor
Copy link
- SGP.28 v1.0, eSIM CI Registration Criteria (Page 5 of 9, 2019-10-24) https://www.gsma.com/newsroom/wp-content/uploads/SGP.28-v1.0.pdf#page=5 - FS.27 v2.0, Security Guidelines for UICC Profiles (Page 25 of 27, 2024-01-30) https://www.gsma.com/solutions-and-impact/technologies/security/wp-content/uploads/2020/12/FS.27-Security-Guidelines-for-UICC-Profiles-v2.0.pdf#page=25
septs added 1 commit 2024-12-10 12:11:18 +01:00
septs added 1 commit 2024-12-10 12:36:41 +01:00
septs added 2 commits 2024-12-10 13:52:15 +01:00
septs added 1 commit 2024-12-10 14:05:10 +01:00
septs added 1 commit 2024-12-10 14:08:28 +01:00
septs added 1 commit 2024-12-10 14:24:09 +01:00
septs added 1 commit 2024-12-11 00:33:39 +01:00
septs added 1 commit 2024-12-11 04:19:18 +01:00
septs added 1 commit 2024-12-11 06:02:19 +01:00
septs added 1 commit 2024-12-11 08:10:56 +01:00
PeterCxy requested changes 2024-12-12 02:04:19 +01:00
app-common/src/main/java/im/angry/openeuicc/ui/EuiccInfoActivity.kt
@ -121,0 +107,4 @@
// FS.27 v2.0, Security Guidelines for UICC Profiles (Page 25 of 27, 2024-01-30)
// https://www.gsma.com/solutions-and-impact/technologies/security/wp-content/uploads/2024/01/FS.27-Security-Guidelines-for-UICC-Credentials-v2.0-FINAL-23-July.pdf#page=25
val resId = when {
signers.isEmpty() -> R.string.unknown // the case is not mp, but it's is not common
PeterCxy commented 2024-12-12 02:03:28 +01:00
Owner
Copy link

what does mp mean?

what does mp mean?
app-common/src/main/res/values/strings.xml
@ -127,1 +123,3 @@
<string name="unsupported">Unsupported</string>
<string name="euicc_info_ci_type">Certificate Issuer</string>
<string name="euicc_info_ci_gsma_live" translatable="false">GSMA Live CI</string>
<string name="euicc_info_ci_gsma_test" translatable="false">GSMA Test CI</string>
PeterCxy commented 2024-12-12 02:02:38 +01:00
Owner
Copy link

These should not be untranslatable

These should not be untranslatable
app-common/src/main/res/values/strings.xml
@ -128,0 +123,4 @@
<string name="euicc_info_ci_type">Certificate Issuer</string>
<string name="euicc_info_ci_gsma_live" translatable="false">GSMA Live CI</string>
<string name="euicc_info_ci_gsma_test" translatable="false">GSMA Test CI</string>
<string name="euicc_info_ci_independent">Independent eSIM CA</string>
PeterCxy commented 2024-12-12 02:02:17 +01:00
Owner
Copy link

Unknown eSIM CA

Unknown eSIM CA
septs closed this pull request 2024-12-12 03:43:06 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
PeterCxy
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#102
No description provided.
Delete branch "septs:ci-detect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?