PeterCxy/OpenEUICC
22
39
Fork 30
Code Issues 7 Pull requests 3 Projects Releases 9 Wiki Activity Actions

feat: if profile delete confirm text is mismatched then show toast #110

Merged
PeterCxy merged 5 commits from septs/OpenEUICC:profile-delete-unmatched-toast into master 2024-12-13 05:15:16 +01:00
Conversation 1 Commits 5 Files changed 2 +35 -16
septs commented 2024-12-12 09:46:18 +01:00
Contributor
Copy link
No description provided.
septs force-pushed profile-delete-unmatched-toast from 10ca93bc14 to e080e029eb 2024-12-12 09:55:32 +01:00 Compare
septs force-pushed profile-delete-unmatched-toast from e080e029eb to f415468e38 2024-12-12 10:50:24 +01:00 Compare
septs force-pushed profile-delete-unmatched-toast from f415468e38 to d6f5161c34 2024-12-12 11:07:32 +01:00 Compare
PeterCxy requested changes 2024-12-13 04:34:47 +01:00
app-common/src/main/java/im/angry/openeuicc/ui/ProfileDeleteFragment.kt Outdated
@ -27,3 +30,4 @@
}
}
private val iccid: String
PeterCxy commented 2024-12-13 04:31:54 +01:00
Owner
Copy link

There's no point having these two vals just to get() = requireArguments().... Using by lazy might be more appropriate if that's the aim.

There's no point having these two vals just to `get() = requireArguments()...`. Using `by lazy` might be more appropriate if that's the aim.
septs marked this conversation as resolved
app-common/src/main/java/im/angry/openeuicc/ui/ProfileDeleteFragment.kt Outdated
@ -61,0 +78,4 @@
requireContext(),
getString(R.string.toast_profile_delete_unmatched, name),
Toast.LENGTH_LONG
)
PeterCxy commented 2024-12-13 04:33:13 +01:00
Owner
Copy link

.also { show() } removes the need for !!

`.also { show() }` removes the need for `!!`
septs marked this conversation as resolved
app-common/src/main/res/values/strings.xml Outdated
@ -29,6 +29,7 @@
<string name="toast_profile_enable_failed">Cannot switch to new eSIM profile.</string>
<string name="toast_profile_name_too_long">Nickname cannot be longer than 64 characters</string>
<string name="toast_profile_delete_unmatched">The string you entered is not \'%s\', please check your input</string>
PeterCxy commented 2024-12-13 04:34:31 +01:00
Owner
Copy link

unmatched -> mismatched

"Confirmation string mismatch" should be enough as a toast.

unmatched -> mismatched "Confirmation string mismatch" should be enough as a toast.
septs marked this conversation as resolved
septs changed title from feat: if profile delete confirm text is unmatched then show toast to feat: if profile delete confirm text is mismatched then show toast 2024-12-13 04:54:40 +01:00
requested review from PeterCxy 2024-12-13 05:14:07 +01:00
PeterCxy merged commit 55d96c6732 into master 2024-12-13 05:15:16 +01:00
septs deleted branch profile-delete-unmatched-toast 2024-12-13 05:17:27 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterCxy
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PeterCxy/OpenEUICC#110
No description provided.
Delete branch "septs/OpenEUICC:profile-delete-unmatched-toast"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?